diff options
| author | Noel Grandin <noel@peralex.com> | 2014-05-14 09:58:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2014-05-14 08:10:22 +0000 |
| commit | 248145f99e95cc30bb6231a8e5ea4e294f147040 (patch) | |
| tree | c3b5c1e226cc631cde530f2cfb7df2d46f00b8c9 /chart2 | |
| parent | 671eb12dee290607ed66f3b325f28e7bd4695cba (diff) | |
Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/tools/ErrorBar.cxx | 2 | ||||
| -rw-r--r-- | chart2/source/tools/RangeHighlighter.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chart2/source/tools/ErrorBar.cxx b/chart2/source/tools/ErrorBar.cxx index 4bf53386effa..b6c1844cb0ab 100644 --- a/chart2/source/tools/ErrorBar.cxx +++ b/chart2/source/tools/ErrorBar.cxx @@ -176,7 +176,7 @@ void ErrorBar::setPropertyValue( const OUString& rPropName, const uno::Any& rAny namespace { -OUString getSourceRangeStrFromLabeledSequences( uno::Sequence< uno::Reference< chart2::data::XLabeledDataSequence > > aSequences, bool bPositive ) +OUString getSourceRangeStrFromLabeledSequences( const uno::Sequence< uno::Reference< chart2::data::XLabeledDataSequence > >& aSequences, bool bPositive ) { const OUString aRolePrefix( "error-bars" ); OUString aDirection; diff --git a/chart2/source/tools/RangeHighlighter.cxx b/chart2/source/tools/RangeHighlighter.cxx index cc7e431c0b47..8a623988fdd1 100644 --- a/chart2/source/tools/RangeHighlighter.cxx +++ b/chart2/source/tools/RangeHighlighter.cxx @@ -42,7 +42,7 @@ namespace void lcl_fillRanges( Sequence< chart2::data::HighlightedRange > & rOutRanges, - Sequence< OUString > aRangeStrings, + const Sequence< OUString >& aRangeStrings, sal_Int32 nPreferredColor = PREFERED_DEFAULT_COLOR, sal_Int32 nIndex = -1 ) { |