Revert "clang-tidy performance-move-const-arg"

This reverts commit 3d604d1cd6cc70ef96782ef769f0479b509987a8.

comments from sberg:

I assume dropping the std::move from aCurSel(std::move(aSel)) is caused
by performance-move-const-arg's warning "if std::move() is called with
an argument of a trivially-copyable type"
(<https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html>).

For my taste, that approach is too tightly tied to a class's current
implementation details, something that may change over time.  Imagine a
trivially copyable class C with a raw pointer member (where the
lifecycle of the pointed-to object is tracked by some higher-level,
likely broken protocol).  Now, that protocol is fixed and the raw
pointer member is replaced with a std::shared_ptr.  C is no longer
trivially copyable, and the dropped std::move would turn out to be
beneficial again.

(Also, if Clang and clang-tidy did implement the fixed rules for
trivially copyable classes from CWG1734/C++17, where a subset of a
trivially copyable class's copy/move members may be deleted, the above
rule to warn "if std::move() is called with an argument of a
trivially-copyable type" would no longer make sense as written; consider
a trivially copyable class whose copy ctor has been deleted.)

Change-Id: Icb91610e50ed98b8f55fe6323bdfa48c8cb9b4b9
Reviewed-on: https://gerrit.libreoffice.org/60166
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 5 insertions, 5 deletions

diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index d9d4977d384a..4b4602af7589 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -116,11 +116,11 @@ VDataSeriesGroup::VDataSeriesGroup( std::unique_ptr<VDataSeries> pSeries )
     m_aSeriesVector[0] = std::move(pSeries);
 }
 
-VDataSeriesGroup::VDataSeriesGroup(VDataSeriesGroup&& other)
-    : m_aSeriesVector(std::move(other.m_aSeriesVector))
-    , m_bMaxPointCountDirty(other.m_bMaxPointCountDirty)
-    , m_nMaxPointCount(other.m_nMaxPointCount)
-    , m_aListOfCachedYValues(std::move(other.m_aListOfCachedYValues))
+VDataSeriesGroup::VDataSeriesGroup( VDataSeriesGroup&& other )
+        : m_aSeriesVector( std::move(other.m_aSeriesVector) )
+        , m_bMaxPointCountDirty( other.m_bMaxPointCountDirty )
+        , m_nMaxPointCount( std::move(other.m_nMaxPointCount) )
+        , m_aListOfCachedYValues( std::move(other.m_aListOfCachedYValues) )
 {
 }