diff options
| author | Noel Grandin <noel@peralex.com> | 2015-09-04 12:16:17 +0200 |
|---|---|---|
| committer | Björn Michaelsen <bjoern.michaelsen@canonical.com> | 2015-10-20 11:35:31 +0000 |
| commit | 56e6f0da839c53867947d1e06f0e733022df7d0e (patch) | |
| tree | bedad09b04f92578b067b62d51f160be9a389dd1 /chart2 | |
| parent | 9e7e264bdf9459487037345917aea7b35de7e7a0 (diff) | |
new loplugin: badvectorinit
look for places calling the 1-argument vector fill constructor and then
immediately called push_back, which is generally a sign that its
leaving empty slots.
Change-Id: I34e69b8d09cc48c0d409499faaf192b9f86bc517
Reviewed-on: https://gerrit.libreoffice.org/17525
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/view/charttypes/AreaChart.cxx | 6 | ||||
| -rw-r--r-- | chart2/source/view/charttypes/NetChart.cxx | 6 |
2 files changed, 8 insertions, 4 deletions
diff --git a/chart2/source/view/charttypes/AreaChart.cxx b/chart2/source/view/charttypes/AreaChart.cxx index c7d9f70f5ef1..f6f6d7b17d90 100644 --- a/chart2/source/view/charttypes/AreaChart.cxx +++ b/chart2/source/view/charttypes/AreaChart.cxx @@ -592,13 +592,15 @@ namespace void lcl_reorderSeries( ::std::vector< ::std::vector< VDataSeriesGroup > >& rZSlots ) { - ::std::vector< ::std::vector< VDataSeriesGroup > > aRet( rZSlots.size() ); + ::std::vector< ::std::vector< VDataSeriesGroup > > aRet; + aRet.reserve( rZSlots.size() ); ::std::vector< ::std::vector< VDataSeriesGroup > >::reverse_iterator aZIt( rZSlots.rbegin() ); ::std::vector< ::std::vector< VDataSeriesGroup > >::reverse_iterator aZEnd( rZSlots.rend() ); for( ; aZIt != aZEnd; ++aZIt ) { - ::std::vector< VDataSeriesGroup > aXSlot( aZIt->size() ); + ::std::vector< VDataSeriesGroup > aXSlot; + aXSlot.reserve( aZIt->size() ); ::std::vector< VDataSeriesGroup >::reverse_iterator aXIt( aZIt->rbegin() ); ::std::vector< VDataSeriesGroup >::reverse_iterator aXEnd( aZIt->rend() ); diff --git a/chart2/source/view/charttypes/NetChart.cxx b/chart2/source/view/charttypes/NetChart.cxx index 1c0d2cd6bbe8..664c2dcdd5b7 100644 --- a/chart2/source/view/charttypes/NetChart.cxx +++ b/chart2/source/view/charttypes/NetChart.cxx @@ -297,13 +297,15 @@ namespace void lcl_reorderSeries( ::std::vector< ::std::vector< VDataSeriesGroup > >& rZSlots ) { - ::std::vector< ::std::vector< VDataSeriesGroup > > aRet( rZSlots.size() ); + ::std::vector< ::std::vector< VDataSeriesGroup > > aRet; + aRet.reserve( rZSlots.size() ); ::std::vector< ::std::vector< VDataSeriesGroup > >::reverse_iterator aZIt( rZSlots.rbegin() ); ::std::vector< ::std::vector< VDataSeriesGroup > >::reverse_iterator aZEnd( rZSlots.rend() ); for( ; aZIt != aZEnd; ++aZIt ) { - ::std::vector< VDataSeriesGroup > aXSlot( aZIt->size() ); + ::std::vector< VDataSeriesGroup > aXSlot; + aXSlot.reserve( aZIt->size() ); ::std::vector< VDataSeriesGroup >::reverse_iterator aXIt( aZIt->rbegin() ); ::std::vector< VDataSeriesGroup >::reverse_iterator aXEnd( aZIt->rend() ); |