diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2012-03-14 13:27:56 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2012-03-14 13:32:02 +0100 |
commit | 6e67c03dc0225fc66343546b14e902b9d238b1a3 (patch) | |
tree | 6e078783d65e280a721b4e46f0ae0ca6b950f121 /chart2 | |
parent | fe4be5047988782f3143a1af505c5eecb3f2af5a (diff) |
Enable -Wnon-virtual-dtor for GCC 4.6
...which has the necessary features to support it.
Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.
cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.
Includes a patch for libcmis, intended to be upstreamed.
Diffstat (limited to 'chart2')
9 files changed, 25 insertions, 0 deletions
diff --git a/chart2/source/controller/chartapiwrapper/ReferenceSizePropertyProvider.hxx b/chart2/source/controller/chartapiwrapper/ReferenceSizePropertyProvider.hxx index 1740132ccec1..b6ae4c64ed54 100644 --- a/chart2/source/controller/chartapiwrapper/ReferenceSizePropertyProvider.hxx +++ b/chart2/source/controller/chartapiwrapper/ReferenceSizePropertyProvider.hxx @@ -40,6 +40,9 @@ public: virtual void updateReferenceSize() = 0; virtual ::com::sun::star::uno::Any getReferenceSize() = 0; virtual ::com::sun::star::awt::Size getCurrentSizeForReference() = 0; + +protected: + ~ReferenceSizePropertyProvider() {} }; } // namespace wrapper diff --git a/chart2/source/controller/inc/DrawViewWrapper.hxx b/chart2/source/controller/inc/DrawViewWrapper.hxx index fda4898f274c..fb1ce41ee9ff 100644 --- a/chart2/source/controller/inc/DrawViewWrapper.hxx +++ b/chart2/source/controller/inc/DrawViewWrapper.hxx @@ -49,6 +49,9 @@ class MarkHandleProvider public: virtual bool getMarkHandles( SdrHdlList& rHdlList ) =0; virtual bool getFrameDragSingles() =0; + +protected: + ~MarkHandleProvider() {} }; class DrawViewWrapper : public E3dView diff --git a/chart2/source/controller/inc/RangeSelectionListener.hxx b/chart2/source/controller/inc/RangeSelectionListener.hxx index d0a4f97bfbad..70886493d23e 100644 --- a/chart2/source/controller/inc/RangeSelectionListener.hxx +++ b/chart2/source/controller/inc/RangeSelectionListener.hxx @@ -41,6 +41,9 @@ class RangeSelectionListenerParent public: virtual void listeningFinished( const ::rtl::OUString & rNewRange ) = 0; virtual void disposingRangeSelection() = 0; + +protected: + ~RangeSelectionListenerParent() {} }; // ---------------------------------------- diff --git a/chart2/source/controller/inc/TabPageNotifiable.hxx b/chart2/source/controller/inc/TabPageNotifiable.hxx index e34de6eee76a..b3771dbc1848 100644 --- a/chart2/source/controller/inc/TabPageNotifiable.hxx +++ b/chart2/source/controller/inc/TabPageNotifiable.hxx @@ -44,6 +44,9 @@ class TabPageNotifiable public: virtual void setInvalidPage( TabPage * pTabPage ) = 0; virtual void setValidPage( TabPage * pTabPage ) = 0; + +protected: + ~TabPageNotifiable() {} }; } // namespace chart diff --git a/chart2/source/inc/ConfigItemListener.hxx b/chart2/source/inc/ConfigItemListener.hxx index 82a23bbcb7cb..f29e4ea28a04 100644 --- a/chart2/source/inc/ConfigItemListener.hxx +++ b/chart2/source/inc/ConfigItemListener.hxx @@ -38,6 +38,9 @@ class OOO_DLLPUBLIC_CHARTTOOLS ConfigItemListener { public: virtual void notify( const ::rtl::OUString & rPropertyName ) = 0; + +protected: + ~ConfigItemListener() {} }; } // namespace chart diff --git a/chart2/source/inc/chartview/ExplicitValueProvider.hxx b/chart2/source/inc/chartview/ExplicitValueProvider.hxx index 8d944192b2e9..cf20374b75ae 100644 --- a/chart2/source/inc/chartview/ExplicitValueProvider.hxx +++ b/chart2/source/inc/chartview/ExplicitValueProvider.hxx @@ -109,6 +109,9 @@ public: static sal_Int32 getExplicitPercentageNumberFormatKeyForDataLabel( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& xSeriesOrPointProp , const ::com::sun::star::uno::Reference< ::com::sun::star::util::XNumberFormatsSupplier >& xNumberFormatsSupplier ); + +protected: + ~ExplicitValueProvider() {} }; //............................................................................. diff --git a/chart2/source/model/main/UndoManager.cxx b/chart2/source/model/main/UndoManager.cxx index e5e6c46ad7f1..95095db4385a 100644 --- a/chart2/source/model/main/UndoManager.cxx +++ b/chart2/source/model/main/UndoManager.cxx @@ -192,6 +192,7 @@ namespace chart class DummyMutex : public ::framework::IMutex { public: + virtual ~DummyMutex() {} virtual void acquire() { } virtual void release() { } }; diff --git a/chart2/source/view/inc/LegendEntryProvider.hxx b/chart2/source/view/inc/LegendEntryProvider.hxx index fd2c41c338c2..52b4a4b7683e 100644 --- a/chart2/source/view/inc/LegendEntryProvider.hxx +++ b/chart2/source/view/inc/LegendEntryProvider.hxx @@ -89,6 +89,9 @@ public: const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& xContext ) = 0; + +protected: + ~LegendEntryProvider() {} }; } // namespace chart diff --git a/chart2/source/view/inc/MinimumAndMaximumSupplier.hxx b/chart2/source/view/inc/MinimumAndMaximumSupplier.hxx index b84fba786baf..e0c5bd5f5c48 100644 --- a/chart2/source/view/inc/MinimumAndMaximumSupplier.hxx +++ b/chart2/source/view/inc/MinimumAndMaximumSupplier.hxx @@ -65,6 +65,9 @@ public: //return a constant out of ::com::sun::star::chart::TimeUnit that allows to display the smallest distance between occuring dates virtual long calculateTimeResolutionOnXAxis() = 0; virtual void setTimeResolutionOnXAxis( long nTimeResolution, const Date& rNullDate ) = 0; + +protected: + ~MinimumAndMaximumSupplier() {} }; class MergedMinimumAndMaximumSupplier : public MinimumAndMaximumSupplier |