diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2014-10-08 14:52:48 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2014-10-08 20:45:11 +0100 |
| commit | 0ac722ccdf75c1d1e8f8cc6c031238a44a5edb0b (patch) | |
| tree | 2144e00385aa96b28774332a3587325b9bb46a19 /chart2 | |
| parent | c53945940369c6480c1f3115fdb3d8f96e974676 (diff) | |
coverity#1237352 Dereference after null check
Change-Id: Ia9cb84bb0924915d4611c5f18d2a0d19b4198d94
Diffstat (limited to 'chart2')
| -rwxr-xr-x | chart2/source/view/charttypes/GL3DBarChart.cxx | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index ec5855d6670a..cd2738460ad2 100755 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -570,11 +570,7 @@ GL3DBarChart::GL3DBarChart( osl_getSystemTime(&maDataUpdateStartTime); osl_getSystemTime(&maDataUpdateEndTime); } - Size aSize; - if (mpWindow) - { - aSize = mpWindow->GetSizePixel(); - } + Size aSize = mpWindow->GetSizePixel(); mpRenderer->SetSize(aSize); mpWindow->setRenderer(this); mpWindow->getContext().makeCurrent(); @@ -602,7 +598,7 @@ GL3DBarChart::~GL3DBarChart() joinRenderThread(); - if(mbValidContext && mpWindow) + if(mbValidContext) mpWindow->setRenderer(NULL); } |