summaryrefslogtreecommitdiff
path: root/chart2
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-18 15:57:09 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-22 08:14:02 +0200
commit163086a649f1562d43281c7a0de3ee31fd818b31 (patch)
tree219e4095fb44f2126a371fcd1c64890753f2b7f5 /chart2
parent6921cde3917dcb4f420b50823394f84c3c8348c9 (diff)
loplugin:virtualdead unused param in ResourceChangeListener
Change-Id: I6bfaef6694ec654889ddf1f300851f323bcc56b3 Reviewed-on: https://gerrit.libreoffice.org/81272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'chart2')
-rw-r--r--chart2/source/controller/dialogs/ChangingResource.hxx2
-rw-r--r--chart2/source/controller/dialogs/ChartTypeDialogController.cxx2
-rw-r--r--chart2/source/controller/dialogs/tp_ChartType.cxx20
-rw-r--r--chart2/source/controller/dialogs/tp_ChartType.hxx2
4 files changed, 13 insertions, 13 deletions
diff --git a/chart2/source/controller/dialogs/ChangingResource.hxx b/chart2/source/controller/dialogs/ChangingResource.hxx
index 251fdf5cb7b6..90f3033ceebd 100644
--- a/chart2/source/controller/dialogs/ChangingResource.hxx
+++ b/chart2/source/controller/dialogs/ChangingResource.hxx
@@ -27,7 +27,7 @@ class ChangingResource;
class ResourceChangeListener
{
public:
- virtual void stateChanged( ChangingResource* pResource ) = 0;
+ virtual void stateChanged() = 0;
virtual ~ResourceChangeListener();
};
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index bbe3c1fd82d5..541236e4fa40 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -1193,7 +1193,7 @@ void CombiColumnLineChartDialogController::setTemplateProperties( const uno::Ref
IMPL_LINK_NOARG(CombiColumnLineChartDialogController, ChangeLineCountHdl, weld::SpinButton&, void)
{
if( m_pChangeListener )
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
void CombiColumnLineChartDialogController::adjustParameterToSubType( ChartTypeParameter& rParameter )
{
diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx
index f46192b5a880..a9db960a0417 100644
--- a/chart2/source/controller/dialogs/tp_ChartType.cxx
+++ b/chart2/source/controller/dialogs/tp_ChartType.cxx
@@ -105,13 +105,13 @@ void Dim3DLookResourceGroup::fillParameter( ChartTypeParameter& rParameter )
IMPL_LINK_NOARG(Dim3DLookResourceGroup, Dim3DLookCheckHdl, weld::ToggleButton&, void)
{
if(m_pChangeListener)
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
IMPL_LINK_NOARG(Dim3DLookResourceGroup, SelectSchemeHdl, weld::ComboBox&, void)
{
if(m_pChangeListener)
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
class SortByXValuesResourceGroup : public ChangingResource
@@ -156,7 +156,7 @@ void SortByXValuesResourceGroup::fillParameter( ChartTypeParameter& rParameter )
IMPL_LINK_NOARG(SortByXValuesResourceGroup, SortByXValuesCheckHdl, weld::ToggleButton&, void)
{
if(m_pChangeListener)
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
class StackingResourceGroup : public ChangingResource
@@ -251,13 +251,13 @@ IMPL_LINK( StackingResourceGroup, StackingChangeHdl, weld::ToggleButton&, rRadio
//first uncheck of previous button -> ignore that call
//the second call gives the check of the new button
if (m_pChangeListener && rRadio.get_active())
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
IMPL_LINK_NOARG(StackingResourceGroup, StackingEnableHdl, weld::ToggleButton&, void)
{
if( m_pChangeListener )
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
class SplinePropertiesDialog : public weld::GenericDialogController
@@ -506,7 +506,7 @@ void SplineResourceGroup::fillParameter( ChartTypeParameter& rParameter )
IMPL_LINK_NOARG(SplineResourceGroup, LineTypeChangeHdl, weld::ComboBox&, void)
{
if( m_pChangeListener )
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
IMPL_LINK_NOARG(SplineResourceGroup, SplineDetailsDialogHdl, weld::Button&, void)
@@ -520,7 +520,7 @@ IMPL_LINK_NOARG(SplineResourceGroup, SplineDetailsDialogHdl, weld::Button&, void
if (getSplinePropertiesDialog().run() == RET_OK)
{
if( m_pChangeListener )
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
else
{
@@ -541,7 +541,7 @@ IMPL_LINK_NOARG(SplineResourceGroup, SteppedDetailsDialogHdl, weld::Button&, voi
if (getSteppedPropertiesDialog().run() == RET_OK)
{
if( m_pChangeListener )
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
else
{
@@ -598,7 +598,7 @@ void GeometryResourceGroup::fillParameter(ChartTypeParameter& rParameter)
IMPL_LINK_NOARG(GeometryResourceGroup, GeometryChangeHdl, weld::TreeView&, void)
{
if( m_pChangeListener )
- m_pChangeListener->stateChanged(this);
+ m_pChangeListener->stateChanged();
}
ChartTypeTabPage::ChartTypeTabPage(weld::Container* pPage, weld::DialogController* pController, const uno::Reference< XChartDocument >& xChartModel,
@@ -725,7 +725,7 @@ void ChartTypeTabPage::commitToModel( const ChartTypeParameter& rParameter )
m_pCurrentMainType->commitToModel( rParameter, m_xChartModel );
}
-void ChartTypeTabPage::stateChanged( ChangingResource* /*pResource*/ )
+void ChartTypeTabPage::stateChanged()
{
if(m_nChangingCalls)
return;
diff --git a/chart2/source/controller/dialogs/tp_ChartType.hxx b/chart2/source/controller/dialogs/tp_ChartType.hxx
index fadeee06e5a8..a9a15cb2f7c0 100644
--- a/chart2/source/controller/dialogs/tp_ChartType.hxx
+++ b/chart2/source/controller/dialogs/tp_ChartType.hxx
@@ -61,7 +61,7 @@ private:
void fillAllControls( const ChartTypeParameter& rParameter, bool bAlsoResetSubTypeList=true );
ChartTypeParameter getCurrentParamter() const;
- virtual void stateChanged( ChangingResource* pResource ) override;
+ virtual void stateChanged() override;
void commitToModel( const ChartTypeParameter& rParameter );
void selectMainType();