diff options
| author | Muhammet Kara <muhammet.kara@collabora.com> | 2020-03-18 13:56:43 +0300 |
|---|---|---|
| committer | Jan Holesovsky <kendy@collabora.com> | 2020-11-13 14:34:14 +0100 |
| commit | 5858f628829ccd14e4915c138d798e03dba20edc (patch) | |
| tree | bf44ee97db027c9a5ec53201b9d6a6e7949cfb88 /chart2 | |
| parent | ca35aea6ed6481c4b090eff2258412684b3e7099 (diff) | |
Sidebar tdf#92768: Fix title & subtitle checkboxes on the ChartDeck
Turns out the 2nd part of tdf#92768 was not implemented yet, so it is
still necessary to remove the title/subtitle for good, otherwise we set
the "Visibility" property, but nothing actually reads that when
rendering.
So the titles now work as they did before the regression. An uncheck action
removes the title/subtitle, and a check action just makes the existing
title/subtitle visible or creates a new one if it doesn't exist
Change-Id: I23122d1be2d95af878b824ba194bd1aeed5f4f89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90692
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105737
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/controller/sidebar/ChartElementsPanel.cxx | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx b/chart2/source/controller/sidebar/ChartElementsPanel.cxx index 4158924fbfb0..c380459cfd9f 100644 --- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx +++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx @@ -663,7 +663,9 @@ void ChartElementsPanel::setTitleVisible(TitleHelper::eTitleType eTitle, bool bV } else { - TitleHelper::hideTitle(eTitle, mxModel); + // TODO tdf#92768 use TitleHelper::hideTitle() here once there is + // rendering suport for the property "Visible" + TitleHelper::removeTitle(eTitle, mxModel); } } |