loplugin:constantparam in chart2

Change-Id: I9adcf4516107aaa960463be13090c2ac15685e09
Reviewed-on: https://gerrit.libreoffice.org/23833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

20 files changed, 31 insertions, 47 deletions

diff --git a/chart2/source/controller/accessibility/AccessibleBase.cxx b/chart2/source/controller/accessibility/AccessibleBase.cxx
index 68886667a624..587a82773f28 100644
--- a/chart2/source/controller/accessibility/AccessibleBase.cxx
+++ b/chart2/source/controller/accessibility/AccessibleBase.cxx
@@ -283,7 +283,7 @@ bool AccessibleBase::ImplUpdateChildren()
             }
             else if ( aIt->isAdditionalShape() )
             {
-                AddChild( new AccessibleChartShape( aAccInfo, true, false ) );
+                AddChild( new AccessibleChartShape( aAccInfo ) );
             }
         }
         bResult = true;
diff --git a/chart2/source/controller/accessibility/AccessibleChartElement.cxx b/chart2/source/controller/accessibility/AccessibleChartElement.cxx
index 375f63c38d55..cb6faa5cc6cb 100644
--- a/chart2/source/controller/accessibility/AccessibleChartElement.cxx
+++ b/chart2/source/controller/accessibility/AccessibleChartElement.cxx
@@ -50,9 +50,8 @@ namespace chart
 
 AccessibleChartElement::AccessibleChartElement(
     const AccessibleElementInfo & rAccInfo,
-    bool bMayHaveChildren,
-    bool bAlwaysTransparent /* default: false */ ) :
-        impl::AccessibleChartElement_Base( rAccInfo, bMayHaveChildren, bAlwaysTransparent ),
+    bool bMayHaveChildren ) :
+        impl::AccessibleChartElement_Base( rAccInfo, bMayHaveChildren, false/*bAlwaysTransparent*/ ),
         m_bHasText( false )
 {
     AddState( AccessibleStateType::TRANSIENT );
diff --git a/chart2/source/controller/accessibility/AccessibleChartElement.hxx b/chart2/source/controller/accessibility/AccessibleChartElement.hxx
index b6aef8b30112..e68d8df75843 100644
--- a/chart2/source/controller/accessibility/AccessibleChartElement.hxx
+++ b/chart2/source/controller/accessibility/AccessibleChartElement.hxx
@@ -69,8 +69,7 @@ class AccessibleChartElement :
 {
 public:
     AccessibleChartElement( const AccessibleElementInfo & rAccInfo,
-                            bool bMayHaveChildren,
-                            bool bAlwaysTransparent = false );
+                            bool bMayHaveChildren );
     virtual ~AccessibleChartElement();
 
     // ________ AccessibleBase ________
diff --git a/chart2/source/controller/accessibility/AccessibleChartShape.cxx b/chart2/source/controller/accessibility/AccessibleChartShape.cxx
index e7b4eed1b6cc..3139f9dd66d2 100644
--- a/chart2/source/controller/accessibility/AccessibleChartShape.cxx
+++ b/chart2/source/controller/accessibility/AccessibleChartShape.cxx
@@ -36,9 +36,8 @@ namespace chart
 {
 
 AccessibleChartShape::AccessibleChartShape(
-        const AccessibleElementInfo& rAccInfo,
-        bool bMayHaveChildren, bool bAlwaysTransparent )
-    :impl::AccessibleChartShape_Base( rAccInfo, bMayHaveChildren, bAlwaysTransparent )
+        const AccessibleElementInfo& rAccInfo )
+    :impl::AccessibleChartShape_Base( rAccInfo, true/*bMayHaveChildren*/, false/*bAlwaysTransparent*/ )
 {
     if ( rAccInfo.m_aOID.isAdditionalShape() )
     {
diff --git a/chart2/source/controller/accessibility/AccessibleChartShape.hxx b/chart2/source/controller/accessibility/AccessibleChartShape.hxx
index 97bbb8d29f1f..e853c50cba96 100644
--- a/chart2/source/controller/accessibility/AccessibleChartShape.hxx
+++ b/chart2/source/controller/accessibility/AccessibleChartShape.hxx
@@ -44,8 +44,7 @@ class AccessibleChartShape :
     public impl::AccessibleChartShape_Base
 {
 public:
-    AccessibleChartShape( const AccessibleElementInfo& rAccInfo,
-        bool bMayHaveChildren, bool bAlwaysTransparent = false );
+    AccessibleChartShape( const AccessibleElementInfo& rAccInfo );
     virtual ~AccessibleChartShape();
 
     // ________ XServiceInfo ________
diff --git a/chart2/source/controller/accessibility/ChartElementFactory.cxx b/chart2/source/controller/accessibility/ChartElementFactory.cxx
index ab26c023c153..0276ac8280a7 100644
--- a/chart2/source/controller/accessibility/ChartElementFactory.cxx
+++ b/chart2/source/controller/accessibility/ChartElementFactory.cxx
@@ -33,7 +33,7 @@ AccessibleBase* ChartElementFactory::CreateChartElement( const AccessibleElement
     {
         case OBJECTTYPE_DATA_POINT:
         case OBJECTTYPE_LEGEND_ENTRY:
-            return new AccessibleChartElement( rAccInfo, false, false );
+            return new AccessibleChartElement( rAccInfo, false );
         case OBJECTTYPE_PAGE:
         case OBJECTTYPE_TITLE:
         case OBJECTTYPE_LEGEND:
@@ -56,7 +56,7 @@ AccessibleBase* ChartElementFactory::CreateChartElement( const AccessibleElement
         case OBJECTTYPE_DATA_STOCK_LOSS:
         case OBJECTTYPE_DATA_STOCK_GAIN:
         case OBJECTTYPE_DATA_CURVE_EQUATION:
-            return new AccessibleChartElement( rAccInfo, true, false );
+            return new AccessibleChartElement( rAccInfo, true );
         case OBJECTTYPE_UNKNOWN:
             break;
         default:
diff --git a/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx b/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
index 1cac58176341..75a1b07481ed 100644
--- a/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
+++ b/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
@@ -96,7 +96,7 @@ OutputDevice * lcl_GetParentRefDevice( const uno::Reference< frame::XModel > & x
 
 }
 
-DrawViewWrapper::DrawViewWrapper( SdrModel* pSdrModel, OutputDevice* pOut, bool bPaintPageForEditMode)
+DrawViewWrapper::DrawViewWrapper( SdrModel* pSdrModel, OutputDevice* pOut)
             : E3dView(pSdrModel, pOut)
             , m_pMarkHandleProvider(nullptr)
             , m_apOutliner(SdrMakeOutliner(OUTLINERMODE_TEXTOBJECT, *pSdrModel))
@@ -104,8 +104,7 @@ DrawViewWrapper::DrawViewWrapper( SdrModel* pSdrModel, OutputDevice* pOut, bool
 {
     SetBufferedOutputAllowed(true);
     SetBufferedOverlayAllowed(true);
-
-    SetPagePaintingAllowed(bPaintPageForEditMode);
+    SetPagePaintingAllowed(true);
 
     // #i12587# support for shapes in chart
     SdrOutliner* pOutliner = getOutliner();
diff --git a/chart2/source/controller/inc/DrawViewWrapper.hxx b/chart2/source/controller/inc/DrawViewWrapper.hxx
index 53a4c0582dc8..f6d9c889d78b 100644
--- a/chart2/source/controller/inc/DrawViewWrapper.hxx
+++ b/chart2/source/controller/inc/DrawViewWrapper.hxx
@@ -45,7 +45,7 @@ protected:
 class DrawViewWrapper : public E3dView
 {
 public:
-    DrawViewWrapper(SdrModel* pModel, OutputDevice* pOut, bool bPaintPageForEditMode);
+    DrawViewWrapper(SdrModel* pModel, OutputDevice* pOut);
     virtual ~DrawViewWrapper();
 
     //triggers the use of an updated first page
diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx
index b1eee73c03a9..780601138e80 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -785,7 +785,7 @@ void ChartController::impl_createDrawViewController()
     {
         if( m_pDrawModelWrapper )
         {
-            m_pDrawViewWrapper = new DrawViewWrapper(&m_pDrawModelWrapper->getSdrModel(),m_pChartWindow,true);
+            m_pDrawViewWrapper = new DrawViewWrapper(&m_pDrawModelWrapper->getSdrModel(),m_pChartWindow);
             m_pDrawViewWrapper->attachParentReferenceDevice( getModel() );
         }
     }
diff --git a/chart2/source/inc/LifeTime.hxx b/chart2/source/inc/LifeTime.hxx
index ef65f007d360..3bb12a864edc 100644
--- a/chart2/source/inc/LifeTime.hxx
+++ b/chart2/source/inc/LifeTime.hxx
@@ -86,8 +86,7 @@ protected:
 
 public:
 OOO_DLLPUBLIC_CHARTTOOLS    CloseableLifeTimeManager( css::util::XCloseable* pCloseable
-        , css::lang::XComponent* pComponent
-        , bool bLongLastingCallsCancelable = false );
+        , css::lang::XComponent* pComponent );
 OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();
 
 OOO_DLLPUBLIC_CHARTTOOLS    bool        impl_isDisposedOrClosed( bool bAssert=true );
diff --git a/chart2/source/model/inc/CartesianCoordinateSystem.hxx b/chart2/source/model/inc/CartesianCoordinateSystem.hxx
index 9466a9a9e179..d17126c9b9e0 100644
--- a/chart2/source/model/inc/CartesianCoordinateSystem.hxx
+++ b/chart2/source/model/inc/CartesianCoordinateSystem.hxx
@@ -29,8 +29,7 @@ class CartesianCoordinateSystem : public BaseCoordinateSystem
 public:
     explicit CartesianCoordinateSystem(
         const css::uno::Reference< css::uno::XComponentContext > & xContext,
-        sal_Int32 nDimensionCount = 2,
-        bool bSwapXAndYAxis = false );
+        sal_Int32 nDimensionCount = 2 );
     explicit CartesianCoordinateSystem( const CartesianCoordinateSystem & rSource );
     virtual ~CartesianCoordinateSystem();
 
diff --git a/chart2/source/model/inc/PolarCoordinateSystem.hxx b/chart2/source/model/inc/PolarCoordinateSystem.hxx
index abd8a6bff923..ba4def86ec79 100644
--- a/chart2/source/model/inc/PolarCoordinateSystem.hxx
+++ b/chart2/source/model/inc/PolarCoordinateSystem.hxx
@@ -29,8 +29,7 @@ class PolarCoordinateSystem : public BaseCoordinateSystem
 public:
     explicit PolarCoordinateSystem(
         const css::uno::Reference< css::uno::XComponentContext > & xContext,
-        sal_Int32 nDimensionCount = 2,
-        bool bSwapXAndYAxis = false );
+        sal_Int32 nDimensionCount = 2 );
     explicit PolarCoordinateSystem( const PolarCoordinateSystem & rSource );
     virtual ~PolarCoordinateSystem();
 
diff --git a/chart2/source/model/main/CartesianCoordinateSystem.cxx b/chart2/source/model/main/CartesianCoordinateSystem.cxx
index 4e1409f6d7ae..3e49456885ad 100644
--- a/chart2/source/model/main/CartesianCoordinateSystem.cxx
+++ b/chart2/source/model/main/CartesianCoordinateSystem.cxx
@@ -47,9 +47,8 @@ namespace chart
 // explicit
 CartesianCoordinateSystem::CartesianCoordinateSystem(
     const uno::Reference< uno::XComponentContext > & xContext,
-    sal_Int32 nDimensionCount /* = 2 */,
-    bool bSwapXAndYAxis /* = sal_False */ ) :
-        BaseCoordinateSystem( xContext, nDimensionCount, bSwapXAndYAxis )
+    sal_Int32 nDimensionCount /* = 2 */ ) :
+        BaseCoordinateSystem( xContext, nDimensionCount, false/*bSwapXAndYAxis*/ )
 {}
 
 CartesianCoordinateSystem::CartesianCoordinateSystem(
@@ -115,7 +114,7 @@ css::uno::Sequence< OUString > SAL_CALL CartesianCoordinateSystem::getSupportedS
 
 CartesianCoordinateSystem2d::CartesianCoordinateSystem2d(
     const uno::Reference< uno::XComponentContext > & xContext ) :
-        CartesianCoordinateSystem( xContext, 2, false )
+        CartesianCoordinateSystem( xContext, 2 )
 {}
 
 CartesianCoordinateSystem2d::~CartesianCoordinateSystem2d()
@@ -158,7 +157,7 @@ css::uno::Sequence< OUString > SAL_CALL CartesianCoordinateSystem2d::getSupporte
 
 CartesianCoordinateSystem3d::CartesianCoordinateSystem3d(
     const uno::Reference< uno::XComponentContext > & xContext ) :
-        CartesianCoordinateSystem( xContext, 3, false )
+        CartesianCoordinateSystem( xContext, 3 )
 {}
 
 CartesianCoordinateSystem3d::~CartesianCoordinateSystem3d()
diff --git a/chart2/source/model/main/PolarCoordinateSystem.cxx b/chart2/source/model/main/PolarCoordinateSystem.cxx
index 96c9bf2f915f..525f3fec8d0a 100644
--- a/chart2/source/model/main/PolarCoordinateSystem.cxx
+++ b/chart2/source/model/main/PolarCoordinateSystem.cxx
@@ -47,9 +47,8 @@ namespace chart
 // explicit
 PolarCoordinateSystem::PolarCoordinateSystem(
     const uno::Reference< uno::XComponentContext > & xContext,
-    sal_Int32 nDimensionCount /* = 2 */,
-    bool bSwapXAndYAxis /* = sal_False */ ) :
-        BaseCoordinateSystem( xContext, nDimensionCount, bSwapXAndYAxis )
+    sal_Int32 nDimensionCount /* = 2 */ ) :
+        BaseCoordinateSystem( xContext, nDimensionCount, false/*bSwapXAndYAxis*/ )
 {}
 
 PolarCoordinateSystem::PolarCoordinateSystem(
@@ -115,7 +114,7 @@ css::uno::Sequence< OUString > SAL_CALL PolarCoordinateSystem::getSupportedServi
 
 PolarCoordinateSystem2d::PolarCoordinateSystem2d(
     const uno::Reference< uno::XComponentContext > & xContext ) :
-        PolarCoordinateSystem( xContext, 2, false )
+        PolarCoordinateSystem( xContext, 2 )
 {}
 
 PolarCoordinateSystem2d::~PolarCoordinateSystem2d()
@@ -158,7 +157,7 @@ css::uno::Sequence< OUString > SAL_CALL PolarCoordinateSystem2d::getSupportedSer
 
 PolarCoordinateSystem3d::PolarCoordinateSystem3d(
     const uno::Reference< uno::XComponentContext > & xContext ) :
-        PolarCoordinateSystem( xContext, 3, false )
+        PolarCoordinateSystem( xContext, 3 )
 {}
 
 PolarCoordinateSystem3d::~PolarCoordinateSystem3d()
diff --git a/chart2/source/model/template/BubbleChartType.cxx b/chart2/source/model/template/BubbleChartType.cxx
index 09ce013c4df6..12ece4617286 100644
--- a/chart2/source/model/template/BubbleChartType.cxx
+++ b/chart2/source/model/template/BubbleChartType.cxx
@@ -125,8 +125,7 @@ Reference< chart2::XCoordinateSystem > SAL_CALL
            uno::RuntimeException, std::exception)
 {
     Reference< chart2::XCoordinateSystem > xResult(
-        new CartesianCoordinateSystem(
-            GetComponentContext(), DimensionCount, /* bSwapXAndYAxis */ false ));
+        new CartesianCoordinateSystem( GetComponentContext(), DimensionCount ));
 
     for( sal_Int32 i=0; i<DimensionCount; ++i )
     {
diff --git a/chart2/source/model/template/ChartType.cxx b/chart2/source/model/template/ChartType.cxx
index bd6162828393..7c402f20317d 100644
--- a/chart2/source/model/template/ChartType.cxx
+++ b/chart2/source/model/template/ChartType.cxx
@@ -78,8 +78,7 @@ Reference< chart2::XCoordinateSystem > SAL_CALL
            uno::RuntimeException, std::exception)
 {
     Reference< chart2::XCoordinateSystem > xResult(
-        new CartesianCoordinateSystem(
-            GetComponentContext(), DimensionCount, /* bSwapXAndYAxis */ false ));
+        new CartesianCoordinateSystem( GetComponentContext(), DimensionCount ));
 
     for( sal_Int32 i=0; i<DimensionCount; ++i )
     {
diff --git a/chart2/source/model/template/NetChartType.cxx b/chart2/source/model/template/NetChartType.cxx
index fc745a6077a1..7b2ee98baef7 100644
--- a/chart2/source/model/template/NetChartType.cxx
+++ b/chart2/source/model/template/NetChartType.cxx
@@ -66,8 +66,7 @@ Reference< XCoordinateSystem > SAL_CALL
             static_cast< ::cppu::OWeakObject* >( this ), 0 );
 
     Reference< XCoordinateSystem > xResult(
-        new PolarCoordinateSystem(
-            GetComponentContext(), DimensionCount, /* bSwapXAndYAxis */ false ));
+        new PolarCoordinateSystem( GetComponentContext(), DimensionCount ));
 
     Reference< XAxis > xAxis( xResult->getAxisByDimension( 0, MAIN_AXIS_INDEX ) );
     if( xAxis.is() )
diff --git a/chart2/source/model/template/PieChartType.cxx b/chart2/source/model/template/PieChartType.cxx
index 568966f035c7..f6c2975986a5 100644
--- a/chart2/source/model/template/PieChartType.cxx
+++ b/chart2/source/model/template/PieChartType.cxx
@@ -164,8 +164,7 @@ Reference< chart2::XCoordinateSystem > SAL_CALL
            uno::RuntimeException, std::exception)
 {
     Reference< chart2::XCoordinateSystem > xResult(
-        new PolarCoordinateSystem(
-            GetComponentContext(), DimensionCount, /* bSwapXAndYAxis */ false ));
+        new PolarCoordinateSystem( GetComponentContext(), DimensionCount ));
 
     for( sal_Int32 i=0; i<DimensionCount; ++i )
     {
diff --git a/chart2/source/model/template/ScatterChartType.cxx b/chart2/source/model/template/ScatterChartType.cxx
index 0849a408e989..f4466f903d82 100644
--- a/chart2/source/model/template/ScatterChartType.cxx
+++ b/chart2/source/model/template/ScatterChartType.cxx
@@ -183,8 +183,7 @@ Reference< chart2::XCoordinateSystem > SAL_CALL
            uno::RuntimeException, std::exception)
 {
     Reference< chart2::XCoordinateSystem > xResult(
-        new CartesianCoordinateSystem(
-            GetComponentContext(), DimensionCount, /* bSwapXAndYAxis */ false ));
+        new CartesianCoordinateSystem( GetComponentContext(), DimensionCount ));
 
     for( sal_Int32 i=0; i<DimensionCount; ++i )
     {
diff --git a/chart2/source/tools/LifeTime.cxx b/chart2/source/tools/LifeTime.cxx
index 2378ad06c24d..a802287b0550 100644
--- a/chart2/source/tools/LifeTime.cxx
+++ b/chart2/source/tools/LifeTime.cxx
@@ -162,9 +162,8 @@ bool LifeTimeManager::dispose()
 }
 
 CloseableLifeTimeManager::CloseableLifeTimeManager( css::util::XCloseable* pCloseable
-        , css::lang::XComponent* pComponent
-        , bool bLongLastingCallsCancelable )
-        : LifeTimeManager( pComponent, bLongLastingCallsCancelable )
+        , css::lang::XComponent* pComponent )
+        : LifeTimeManager( pComponent, false/*bLongLastingCallsCancelable*/ )
         , m_pCloseable(pCloseable)
 {
     impl_init();