diff options
| author | Noel Grandin <noel@peralex.com> | 2014-06-25 14:57:44 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-07-11 14:12:25 +0200 |
| commit | dac4ca5f682fdd0c3eee7f7ee1d98c9b3c8b7ce4 (patch) | |
| tree | f0f66445c3f396759c41d7e3294e728653dbfa88 /chart2 | |
| parent | 28b6325901138a6267320902ec889fc434ddde91 (diff) | |
new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
Diffstat (limited to 'chart2')
| -rw-r--r-- | chart2/source/inc/charttoolsdllapi.hxx | 3 | ||||
| -rw-r--r-- | chart2/source/model/main/_serviceregistration_model.cxx | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/chart2/source/inc/charttoolsdllapi.hxx b/chart2/source/inc/charttoolsdllapi.hxx index 570e92b97192..0ae3cc41a096 100644 --- a/chart2/source/inc/charttoolsdllapi.hxx +++ b/chart2/source/inc/charttoolsdllapi.hxx @@ -30,6 +30,9 @@ #define OOO_DLLPUBLIC_CHARTTOOLS SAL_DLLPUBLIC_IMPORT #endif +extern "C" SAL_DLLPUBLIC_EXPORT void * SAL_CALL charttools_component_getFactory( + const sal_Char * pImplName, void * pServiceManager, void * pRegistryKey ); + #endif /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/model/main/_serviceregistration_model.cxx b/chart2/source/model/main/_serviceregistration_model.cxx index 911eb0509a3d..0245532004ca 100644 --- a/chart2/source/model/main/_serviceregistration_model.cxx +++ b/chart2/source/model/main/_serviceregistration_model.cxx @@ -35,6 +35,7 @@ #include "XMLFilter.hxx" #include "_serviceregistration_charttypes.hxx" +#include "charttoolsdllapi.hxx" static const struct ::cppu::ImplementationEntry g_entries_chart2_model[] = { @@ -174,8 +175,6 @@ static const struct ::cppu::ImplementationEntry g_entries_chart2_model[] = // component exports extern "C" { -SAL_DLLPUBLIC_EXPORT void * SAL_CALL charttools_component_getFactory( - const sal_Char * pImplName, void * pServiceManager, void * pRegistryKey ); SAL_DLLPUBLIC_EXPORT void * SAL_CALL chartcore_component_getFactory( const sal_Char * pImplName, void * pServiceManager, void * pRegistryKey ) { |