diff options
| author | Marcos Paulo de Souza <marcos.souza.org@gmail.com> | 2013-03-07 10:25:27 -0300 |
|---|---|---|
| committer | Fridrich Strba <fridrich@documentfoundation.org> | 2013-03-08 04:31:03 +0000 |
| commit | 75e6856b081ca29e3e0f19493780d9f8fa6d315c (patch) | |
| tree | ccf9eff69dfcceee951880cb9381f37940ae47d0 /codemaker/source/commonjava | |
| parent | 8035a3af260729ee47a1d805811e17d06d035e3d (diff) | |
fdo#57950: Remove chained appends in codemaker
And another cleanups like removing RTL_CONST* macros and other simple
things.
Much more can be done inside codemaker.
Change-Id: I338e1c0e88558124741c6202896355533535a129
Reviewed-on: https://gerrit.libreoffice.org/2583
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Diffstat (limited to 'codemaker/source/commonjava')
| -rw-r--r-- | codemaker/source/commonjava/commonjava.cxx | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/codemaker/source/commonjava/commonjava.cxx b/codemaker/source/commonjava/commonjava.cxx index 8c01be992375..e5f6eca8fc5d 100644 --- a/codemaker/source/commonjava/commonjava.cxx +++ b/codemaker/source/commonjava/commonjava.cxx @@ -39,16 +39,15 @@ namespace codemaker { namespace java { -rtl::OString translateUnoToJavaType( +OString translateUnoToJavaType( codemaker::UnoType::Sort sort, RTTypeClass typeClass, - rtl::OString const & nucleus, bool referenceType) + OString const & nucleus, bool referenceType) { - rtl::OStringBuffer buf; + OStringBuffer buf; if (sort == codemaker::UnoType::SORT_COMPLEX) { - if (typeClass == RT_TYPE_INTERFACE - && nucleus == rtl::OString("com/sun/star/uno/XInterface")) + if (typeClass == RT_TYPE_INTERFACE && nucleus == "com/sun/star/uno/XInterface") { - buf.append(RTL_CONSTASCII_STRINGPARAM("java/lang/Object")); + buf.append("java/lang/Object"); } else { //TODO: check that nucleus is a valid (Java-modified UTF-8) // identifier @@ -145,10 +144,7 @@ rtl::OString translateUnoToJavaIdentifier( || identifier == "volatile" || identifier == "while") { - rtl::OStringBuffer buf(prefix); - buf.append('_'); - buf.append(identifier); - return buf.makeStringAndClear(); + return prefix + "_" + identifier; } else { return identifier; } |