Convert indexOf->startsWith and lastIndexOf->endsWith

This is both an optimisation and a cleanup.

This converts code like
aStr.indexOf("XX") == 0
to
aStr.startsWith("XX")
and converts code like
aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
aStr.endsWith("XXX")

Note that in general
aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669

1 files changed, 2 insertions, 9 deletions

diff --git a/codemaker/source/codemaker/global.cxx b/codemaker/source/codemaker/global.cxx
index 17c6feca6e3c..bfe77c452af8 100644
--- a/codemaker/source/codemaker/global.cxx
+++ b/codemaker/source/codemaker/global.cxx
@@ -237,23 +237,16 @@ sal_Bool removeTypeFile(const OString& fileName)
     return sal_False;
 }
 
-static sal_Bool isFileUrl(const OString& fileName)
-{
-    if (fileName.indexOf("file://") == 0 )
-        return sal_True;
-    return sal_False;
-}
-
 OUString convertToFileUrl(const OString& fileName)
 {
-    if ( isFileUrl(fileName) )
+    if ( fileName.startsWith("file://") )
     {
         return OStringToOUString(fileName, osl_getThreadTextEncoding());
     }
 
     OUString uUrlFileName;
     OUString uFileName(fileName.getStr(), fileName.getLength(), osl_getThreadTextEncoding());
-    if ( fileName.indexOf('.') == 0 || fileName.indexOf(SEPARATOR) < 0 )
+    if ( fileName.startsWith(".") || fileName.indexOf(SEPARATOR) < 0 )
     {
         OUString uWorkingDir;
         if (osl_getProcessWorkingDir(&uWorkingDir.pData) != osl_Process_E_None)