diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2022-04-21 21:09:07 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-04-22 13:27:56 +0200 |
| commit | 9820f11ad2b1ef32e5527eec519b0a7c766e2602 (patch) | |
| tree | 2ffa9a42bed16ab9a790d78b8f42a76996fdbe01 /codemaker | |
| parent | e4d1731ba3e8bac2801d1b76cfb66bf7f9795468 (diff) | |
address review comments on "use more string in unoidl.."
on
commit 2d9291b9433c9645b0870525211f74bfb1151555
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu Apr 21 12:53:15 2022 +0200
use more string_view in unoidl,codemaker
Primarily reverting the findEntity call-chain to use OUString
instead of std::u16string_view.
Change-Id: Ib01b9473c859bba3791563df753823bbf0a87ce0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'codemaker')
| -rw-r--r-- | codemaker/source/codemaker/typemanager.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/codemaker/source/codemaker/typemanager.cxx b/codemaker/source/codemaker/typemanager.cxx index c684d048782b..194840ca9d5b 100644 --- a/codemaker/source/codemaker/typemanager.cxx +++ b/codemaker/source/codemaker/typemanager.cxx @@ -33,15 +33,15 @@ TypeManager::TypeManager(): manager_(new unoidl::Manager) {} TypeManager::~TypeManager() {} -void TypeManager::loadProvider(std::u16string_view uri, bool primary) { +void TypeManager::loadProvider(OUString const & uri, bool primary) { rtl::Reference< unoidl::Provider > prov(manager_->addProvider(uri)); if (primary) { primaryProviders_.push_back(prov); } } -bool TypeManager::foundAtPrimaryProvider(std::u16string_view name) const { - if (name.empty()) { +bool TypeManager::foundAtPrimaryProvider(OUString const & name) const { + if (name.isEmpty()) { return !primaryProviders_.empty(); } for (const rtl::Reference< unoidl::Provider >& xProvider : primaryProviders_) @@ -51,7 +51,7 @@ bool TypeManager::foundAtPrimaryProvider(std::u16string_view name) const { } } if (!manager_->findEntity(name).is()) { - throw CannotDumpException(OUString::Concat("Unknown entity '") + name + "'"); + throw CannotDumpException("Unknown entity '" + name + "'"); } return false; } |