diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-18 08:27:05 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-18 09:46:28 +0200 |
| commit | 5fb66ae5595b7435e8954df31473fad15a74b8c2 (patch) | |
| tree | 3b3f0ce3eafa10557a7e78b10851c97ee16c7ebf /codemaker | |
| parent | 181a1b36ac728e3a43e054496ceb53fd3315abdb (diff) | |
clang-tidy readability-simplify-boolean-expr
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64
Reviewed-on: https://gerrit.libreoffice.org/61902
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'codemaker')
| -rw-r--r-- | codemaker/source/codemaker/global.cxx | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/codemaker/source/codemaker/global.cxx b/codemaker/source/codemaker/global.cxx index 8eb506e10e51..e9a9b8f415c1 100644 --- a/codemaker/source/codemaker/global.cxx +++ b/codemaker/source/codemaker/global.cxx @@ -214,10 +214,7 @@ bool makeValidTypeFile(const OString& targetFileName, const OString& tmpFileName bool removeTypeFile(const OString& fileName) { - if ( !unlink(fileName.getStr()) ) - return true; - - return false; + return unlink(fileName.getStr()) == 0; } OUString convertToFileUrl(const OString& fileName) @@ -269,10 +266,7 @@ FileStream::~FileStream() bool FileStream::isValid() const { - if ( m_file ) - return true; - - return false; + return m_file != nullptr; } void FileStream::createTempFile(const OString& sPath) |