diff options
| author | Ashod Nakashian <ashod.nakashian@collabora.co.uk> | 2016-06-14 07:19:20 -0400 |
|---|---|---|
| committer | Ashod Nakashian <ashnakash@gmail.com> | 2016-06-15 21:28:47 +0000 |
| commit | 60e75fb276778459f6055360646d879b8c615d83 (patch) | |
| tree | 332c124a2bff614b1483ab5549e56dbdd743d17a /comphelper/Module_comphelper.mk | |
| parent | b43b7a59ca24927c4f4bd90935b4f0075304abe7 (diff) | |
tdf#98955 hardware_concurrency not ideal for thread pools
A new static member getPreferredConcurrency added to
comphelper::ThreadPool to return a configurable max
number of threads.
By default the new function returns the hardware_concurrency
value provided by std::thread. When MAX_CONCURRENCY envar is
defined, the return value is limited to whatever is set there.
Three call-sites that used std::thread::hardware_concurrency
have been replaced with getPreferredConcurrency.
Unittests added to cover the functionality of the new member.
Unittests are capped to 4 threads.
Change-Id: I3332e393a88a5ed436316fa712ed920a4b37f4af
Reviewed-on: https://gerrit.libreoffice.org/26254
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Diffstat (limited to 'comphelper/Module_comphelper.mk')
| -rw-r--r-- | comphelper/Module_comphelper.mk | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/comphelper/Module_comphelper.mk b/comphelper/Module_comphelper.mk index 2eba43df73f8..e04d230d2069 100644 --- a/comphelper/Module_comphelper.mk +++ b/comphelper/Module_comphelper.mk @@ -28,9 +28,10 @@ $(eval $(call gb_Module_add_subsequentcheck_targets,comphelper,\ )) $(eval $(call gb_Module_add_check_targets,comphelper,\ + CppunitTest_comphelper_threadpool_test \ CppunitTest_comphelper_syntaxhighlight_test \ CppunitTest_comphelper_variadictemplates_test \ - CppunitTest_comphelper_ifcontainer \ + CppunitTest_comphelper_ifcontainer \ CppunitTest_comphelper_test \ )) |