diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-11-12 08:13:40 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-11-12 16:53:30 +0100 |
| commit | f34ac579fac16fff37bf00fe85d43ad6b938eca7 (patch) | |
| tree | 0747c4d86bbf40a5093fb7a3215dd52a8e8586b2 /comphelper/source | |
| parent | c45753847dfc2b4645dc2f7500a18ec2c5d438df (diff) | |
New loplugin:stringviewparam
...to "Find functions that take rtl::O[U]String parameters that can be
generalized to take std::[u16]string_view instead." (Which in turn can avoid
costly O[U]String constructions, see e.g. loplugin:stringview and subView.)
Some of those functions' call sites, passing plain char string literals, needed
to be adapted when converting them.
Change-Id: I644ab546d7a0ce9e470ab9b3196e3e60d1e812bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105622
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'comphelper/source')
| -rw-r--r-- | comphelper/source/property/propertybag.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/comphelper/source/property/propertybag.cxx b/comphelper/source/property/propertybag.cxx index de230f470150..02e6f78c1287 100644 --- a/comphelper/source/property/propertybag.cxx +++ b/comphelper/source/property/propertybag.cxx @@ -29,7 +29,7 @@ #include <com/sun/star/beans/UnknownPropertyException.hpp> #include <map> - +#include <string_view> namespace comphelper { @@ -66,9 +66,9 @@ namespace comphelper namespace { - void lcl_checkForEmptyName( const bool _allowEmpty, const OUString& _name ) + void lcl_checkForEmptyName( const bool _allowEmpty, std::u16string_view _name ) { - if ( !_allowEmpty && _name.isEmpty() ) + if ( !_allowEmpty && _name.empty() ) throw IllegalArgumentException( "The property name must not be empty.", // TODO: resource |