new compilerplugin returnbyref

Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7

2 files changed, 4 insertions, 4 deletions

diff --git a/comphelper/source/property/propertysethelper.cxx b/comphelper/source/property/propertysethelper.cxx
index 66b7843fc137..eb07e504d8d5 100644
--- a/comphelper/source/property/propertysethelper.cxx
+++ b/comphelper/source/property/propertysethelper.cxx
@@ -40,9 +40,9 @@ public:
 
 PropertyMapEntry const * PropertySetHelperImpl::find( const OUString& aName ) const throw()
 {
-    PropertyMap::const_iterator aIter = mpInfo->getPropertyMap()->find( aName );
+    PropertyMap::const_iterator aIter = mpInfo->getPropertyMap().find( aName );
 
-    if( mpInfo->getPropertyMap()->end() != aIter )
+    if( mpInfo->getPropertyMap().end() != aIter )
     {
         return (*aIter).second;
     }
diff --git a/comphelper/source/property/propertysetinfo.cxx b/comphelper/source/property/propertysetinfo.cxx
index 1f3bb28735c4..df4738d0d38e 100644
--- a/comphelper/source/property/propertysetinfo.cxx
+++ b/comphelper/source/property/propertysetinfo.cxx
@@ -40,7 +40,7 @@ public:
 
     Sequence< Property > getProperties() throw();
 
-    const PropertyMap* getPropertyMap() const throw() { return &maPropertyMap;}
+    const PropertyMap& getPropertyMap() const throw() { return maPropertyMap;}
 
     Property getPropertyByName( const OUString& aName ) throw( UnknownPropertyException );
     bool hasPropertyByName( const OUString& aName ) throw();
@@ -182,7 +182,7 @@ sal_Bool SAL_CALL PropertySetInfo::hasPropertyByName( const OUString& Name ) thr
     return mpMap->hasPropertyByName( Name );
 }
 
-const PropertyMap* PropertySetInfo::getPropertyMap() const throw()
+const PropertyMap& PropertySetInfo::getPropertyMap() const throw()
 {
     return mpMap->getPropertyMap();
 }