diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2017-12-28 09:34:44 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2017-12-28 13:50:47 +0100 |
| commit | 7f15b7ae482be5994c6803b982c13cbc036a734f (patch) | |
| tree | 7f471323c711b40791cbdc308fd595b036916e79 /comphelper | |
| parent | b0203670492d5af7f963e66ef702f36c87b6b694 (diff) | |
Full UBSan in external/firebird
...after 6a312a4a3d642f0f9769df54c0ec25471c9916bd "Prepare external/firebird for
sanitizers". Doing `make check screenshot` on Linux with Clang
-fsanitize=undefined -fsanitize=local-bounds -fsanitize=nullability works now.
Patches that might be unwanted in non-UBSan builds are added to sanitizer.patch
while unproblematic ones are added to always-included ubsan.patch.
CppunitTest_dbaccess_firebird_test, e.g., shows that
comphelper::AsyncEventNotifierAutoJoin::onTerminated called base-class
osl::Thread::onTerminated (which does nothing, anyway) of an already destroyed
object, so just drop that.
Change-Id: If50f442ee6dbe590db843c38681d1c1cade8fa6a
Reviewed-on: https://gerrit.libreoffice.org/47122
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'comphelper')
| -rw-r--r-- | comphelper/source/misc/asyncnotification.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/comphelper/source/misc/asyncnotification.cxx b/comphelper/source/misc/asyncnotification.cxx index ec305e4bdfce..2a2ef6b1c819 100644 --- a/comphelper/source/misc/asyncnotification.cxx +++ b/comphelper/source/misc/asyncnotification.cxx @@ -266,7 +266,6 @@ namespace comphelper { // try to delete "this" m_xImpl->pKeepThisAlive.reset(); - return osl::Thread::onTerminated(); } } // namespace comphelper |