diff options
| author | Michael Stahl <michael.stahl@allotropia.de> | 2022-01-20 12:48:50 +0100 |
|---|---|---|
| committer | Michael Stahl <michael.stahl@allotropia.de> | 2022-03-09 19:00:30 +0100 |
| commit | f9d82db9f73b6e9e20d79fc9392baee28011113b (patch) | |
| tree | 05049d60321a6a69ab137c5ae281a7f27539e26c /comphelper | |
| parent | 5baaae8f89b7d61bc5a9349cb6fd42a5a3423af3 (diff) | |
comphelper: fix UAF in SequenceOutputStreamService dtor
Change-Id: I91f77ee9ab4d509ebee3d04f94a3c63986de0ef1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128657
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
(cherry picked from commit 03e8e1a408eef3c8acc5545416eda9d0938e21f7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128669
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
(cherry picked from commit 512e8c5ebb8cc398ae3ca316de70f008b9646011)
Diffstat (limited to 'comphelper')
| -rw-r--r-- | comphelper/source/streaming/seqoutputstreamserv.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/comphelper/source/streaming/seqoutputstreamserv.cxx b/comphelper/source/streaming/seqoutputstreamserv.cxx index 757df72c3f58..5c7de4d87080 100644 --- a/comphelper/source/streaming/seqoutputstreamserv.cxx +++ b/comphelper/source/streaming/seqoutputstreamserv.cxx @@ -62,8 +62,9 @@ private: ::osl::Mutex m_aMutex; - uno::Reference< io::XOutputStream > m_xOutputStream; + // WARNING: dtor of m_xOutputStream writes into m_aSequence so that must live longer! uno::Sequence< ::sal_Int8 > m_aSequence; + uno::Reference< io::XOutputStream > m_xOutputStream; }; SequenceOutputStreamService::SequenceOutputStreamService() { |