remove counter-productive catch-all blocks

There is no point in these - the rethrow will crash the process
anyway, so trying to recover anything is a waste of time.

And they very unhelpfully obscure the stacktrace of the actual
underlying problem.

Change-Id: I8e4439e5e2c517aa80a1750a05c207d274c73012
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125980
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 4 insertions, 14 deletions

diff --git a/comphelper/source/misc/asyncnotification.cxx b/comphelper/source/misc/asyncnotification.cxx
index e498ce23ba44..e2c5691899d3 100644
--- a/comphelper/source/misc/asyncnotification.cxx
+++ b/comphelper/source/misc/asyncnotification.cxx
@@ -231,26 +231,16 @@ namespace comphelper
     {
         // see salhelper::Thread::launch
         xThis->m_xImpl->pKeepThisAlive = xThis;
-        try {
-            if (!xThis->create()) {
-                throw std::runtime_error("osl::Thread::create failed");
-            }
-        } catch (...) {
-            xThis->m_xImpl->pKeepThisAlive.reset();
-            throw;
+        if (!xThis->create()) {
+            throw std::runtime_error("osl::Thread::create failed");
         }
     }
 
     void AsyncEventNotifierAutoJoin::run()
     {
         // see salhelper::Thread::run
-        try {
-            setName(m_xImpl->name);
-            execute();
-        } catch (...) {
-            onTerminated();
-            throw;
-        }
+        setName(m_xImpl->name);
+        execute();
     }
 
     void AsyncEventNotifierAutoJoin::onTerminated()