diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2019-11-19 15:45:57 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2019-11-19 18:30:47 +0100 |
commit | d273ea2a43886138be553514218c0c3ffda5900f (patch) | |
tree | eb43ab98485536cf8dc8ae468caaef0acfb48c4f /compilerplugins/.gitignore | |
parent | fd6d48cbb8b43aa13d475873f1a5355106b2e649 (diff) |
Fix loplugin:fakebool (clang-cl)
...where it failed with
> [build CXX] setup_native/source/win32/customactions/sellang/sorttree.cxx
> C:/lo-clang/core/setup_native/source/win32/customactions/sellang/sorttree.cxx(43,5): error: CStyleCastExpr, suspicious cast from 'LRESULT' (aka 'long long') to 'BOOL' (aka 'int') [loplugin:fakebool]
> TreeView_SortChildren(hwndTV, dicts, TRUE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> C:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/um\commctrl.h(5227,5): note: expanded from macro 'TreeView_SortChildren'
> (BOOL)SNDMSG((hwnd), TVM_SORTCHILDREN, (WPARAM)(recurse), (LPARAM)(HTREEITEM)(hitem))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> C:/lo-clang/core/setup_native/source/win32/customactions/sellang/sorttree.cxx(43,5): error: conversion from 'LRESULT' (aka 'long long') to 'BOOL' (aka 'int') [loplugin:fakebool]
> TreeView_SortChildren(hwndTV, dicts, TRUE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> C:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/um\commctrl.h(5227,11): note: expanded from macro 'TreeView_SortChildren'
> (BOOL)SNDMSG((hwnd), TVM_SORTCHILDREN, (WPARAM)(recurse), (LPARAM)(HTREEITEM)(hitem))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> C:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/um\prsht.h(73,16): note: expanded from macro 'SNDMSG'
> #define SNDMSG ::SendMessage
> ^
(And the improved check in FakeBool::VisitImplicitCastExpr nicely removes the
need to list all the individual false/true macros.)
Change-Id: I815172f32f493bba336008aaacc00545e61ada7b
Reviewed-on: https://gerrit.libreoffice.org/83215
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/.gitignore')
0 files changed, 0 insertions, 0 deletions