diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2020-08-21 09:26:43 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2020-08-21 12:07:30 +0200 |
commit | a8ab80c58a1330672d7a8eefd73b2eb9cb6c134c (patch) | |
tree | d6cd0d1af8068b8628485d691dbf499bf0b97ef4 /compilerplugins/README | |
parent | 17798a503bc67f2a38f4b558e37447d1ea8f4623 (diff) |
Silence some clang-cl loplugin:stringstatic
For one, do not warn about global declarations in included files, as generally
not all uses of the variable are seen to decided whether it would be good to
replace. That covers cases like
> In file included from dtrans/source/win32/dtobj/DataFmtTransl.cxx:26:
> dtrans/source/win32/dtobj/MimeAttrib.hxx(29,16): error: rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic]
> const OUString CHARSET_UTF16 ("utf-16");
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
For another, do not warn about variables whose pData member is used. That covers
cases like
> sal/osl/w32/procimpl.cxx(347,20): error: rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic]
> const OUString ENV_COMSPEC ("COMSPEC");
> ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I75c1048098b63164bdb583695951f73964cb24f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101134
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/README')
0 files changed, 0 insertions, 0 deletions