diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2022-02-15 15:03:24 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2022-02-17 21:45:06 +0100 |
| commit | d1a2b80b9dc146c7fe63d2657e5506f49d6e5c0d (patch) | |
| tree | 7ceeb7e977c660d5b69bc93e8327674b7ea1ae5d /compilerplugins/clang/constvars.cxx | |
| parent | eed401bc7429f29f1b21cf8e3b08969e011d5692 (diff) | |
Bump compiler plugins Clang baseline to 12.0.1
...as discussed in the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2020-November/086234.html>
"Bump --enable-compiler-plugins Clang baseline?" (and now picked up again at
<https://lists.freedesktop.org/archives/libreoffice/2022-February/088459.html>
"Re: Bump --enable-compiler-plugins Clang baseline?"), and clean up
compilerplugins/clang/ accordingly
Change-Id: I5e81c6fdcc363aeefd6227606225b526fdf7ac16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129989
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/clang/constvars.cxx')
| -rw-r--r-- | compilerplugins/clang/constvars.cxx | 13 |
1 files changed, 4 insertions, 9 deletions
diff --git a/compilerplugins/clang/constvars.cxx b/compilerplugins/clang/constvars.cxx index e496d5f0ad15..2b06f54ea343 100644 --- a/compilerplugins/clang/constvars.cxx +++ b/compilerplugins/clang/constvars.cxx @@ -19,15 +19,10 @@ #include <sys/file.h> #include <unistd.h> -#include "config_clang.h" - #include "plugin.hxx" -#include "compat.hxx" #include "check.hxx" -#if CLANG_VERSION >= 110000 #include "clang/AST/ParentMapContext.h" -#endif /** Look for static vars that are only assigned to once, and never written to, they can be const. @@ -175,7 +170,7 @@ void ConstVars::run() // Implement a marker that disables this plugins warning at a specific site if (sourceString.contains("loplugin:constvars:ignore")) continue; - report(DiagnosticsEngine::Warning, "var can be const", compat::getBeginLoc(v)); + report(DiagnosticsEngine::Warning, "var can be const", v->getBeginLoc()); } } @@ -213,7 +208,7 @@ bool ConstVars::VisitVarDecl(const VarDecl* varDecl) bool ConstVars::VisitCXXForRangeStmt(const CXXForRangeStmt* forStmt) { - if (compat::getBeginLoc(forStmt).isValid() && ignoreLocation(forStmt)) + if (forStmt->getBeginLoc().isValid() && ignoreLocation(forStmt)) return true; const VarDecl* varDecl = forStmt->getLoopVariable(); if (!varDecl) @@ -491,11 +486,11 @@ void ConstVars::check(const VarDecl* varDecl, const Expr* memberExpr) if (bDump) { report(DiagnosticsEngine::Warning, "oh dear, what can the matter be? writtenTo=%0", - compat::getBeginLoc(memberExpr)) + memberExpr->getBeginLoc()) << bCannotBeConst << memberExpr->getSourceRange(); if (parent) { - report(DiagnosticsEngine::Note, "parent over here", compat::getBeginLoc(parent)) + report(DiagnosticsEngine::Note, "parent over here", parent->getBeginLoc()) << parent->getSourceRange(); parent->dump(); } |