diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-03 10:52:46 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-04 08:23:43 +0200 |
| commit | b83ac35bf46ecbebf7f806235eca38a71e521c32 (patch) | |
| tree | 660cb00ba4045c7238e9d43176196339ecf901f0 /compilerplugins/clang/simplifypointertobool.cxx | |
| parent | 7b905c8f1d520ae1aaf4bd2fbb6a3325b404ea95 (diff) | |
loplugin:simplifypointertobool improve (2)
to look for the
x.get() == null
pattern, which can be simplified to
!x
Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/simplifypointertobool.cxx')
| -rw-r--r-- | compilerplugins/clang/simplifypointertobool.cxx | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/compilerplugins/clang/simplifypointertobool.cxx b/compilerplugins/clang/simplifypointertobool.cxx index 4f8abb52c74f..4630556984a3 100644 --- a/compilerplugins/clang/simplifypointertobool.cxx +++ b/compilerplugins/clang/simplifypointertobool.cxx @@ -423,9 +423,7 @@ bool SimplifyPointerToBool::VisitBinaryOperator(BinaryOperator const* binOp) if (ignoreLocation(binOp)) return true; auto opCode = binOp->getOpcode(); - //TODO if (opCode != BO_EQ && opCode != BO_NE) - // return true; - if (opCode != BO_NE) + if (opCode != BO_EQ && opCode != BO_NE) return true; const Expr* possibleMemberCall = nullptr; if (isa<CXXNullPtrLiteralExpr>(binOp->getLHS()->IgnoreParenImpCasts())) |