diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2019-10-06 20:44:39 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2019-10-07 15:21:50 +0200 |
| commit | c8bf651fb9b97eca6af7d1d26c62681cc5c7ec0f (patch) | |
| tree | 8c78c377aa4dc4876d5ee691772ff0342c36d4fe /compilerplugins/clang/stringconcatliterals.cxx | |
| parent | dc8b44bd1d695eb8686fdddbbc7d70cd597fd78b (diff) | |
do not use compiler.getSourceManager().getFilename()
This is a continuation of ff002524c12471668e63837a804b6006f9136a34.
When compiling with icecream, its -frewrite-includes merges
all #include's into one .cxx file and marks them with with line
markers. But SourceManager::getFilename() doesn't take those
into account and so it reports all of those as <stdin>.
So use getFileNameOfSpellingLoc(), which explicitly handles this
case.
And we should probably never ever use SourceManager::getFilename().
Change-Id: Ia194c2e041578e1e199aee2df2f885922ef7e31a
Reviewed-on: https://gerrit.libreoffice.org/80326
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'compilerplugins/clang/stringconcatliterals.cxx')
| -rw-r--r-- | compilerplugins/clang/stringconcatliterals.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compilerplugins/clang/stringconcatliterals.cxx b/compilerplugins/clang/stringconcatliterals.cxx index f6008175f38d..2d2699a09acf 100644 --- a/compilerplugins/clang/stringconcatliterals.cxx +++ b/compilerplugins/clang/stringconcatliterals.cxx @@ -105,7 +105,7 @@ bool StringConcatLiterals::VisitCallExpr(CallExpr const * expr) { // We add an extra " " in the TOOLS_WARN_EXCEPTION macro, which triggers this plugin if (loplugin::isSamePathname( - compiler.getSourceManager().getFilename( + getFileNameOfSpellingLoc( compiler.getSourceManager().getSpellingLoc( compiler.getSourceManager().getImmediateMacroCallerLoc( compiler.getSourceManager().getImmediateMacroCallerLoc( |