diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-07-19 14:53:29 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-07-19 23:05:57 +0200 |
| commit | 5d546de67b44dec23ecfa5a6378e2968912f8253 (patch) | |
| tree | 811691579249f4e70783f239cec9acc312e9785c /compilerplugins/clang/test/implicitboolconversion.cxx | |
| parent | 46bfb9da866c2e7bb37c7f5d8980f378c52f79f8 (diff) | |
Adapt to Clang 12 trunk RecursiveASTVisitor change
<https://github.com/llvm/llvm-project/commit/
5689b38c6a4220cc5f6ba68a56486229b10071bf> "Removed a RecursiveASTVisitor feature
to visit operator kinds with different methods".
That change is incompatible in that before the change individual TraverseUnary*
and TraverseBin* functions were called, while now TraverseUnaryOperator and
TraverseBinaryOperator/TraverseCompoundAssignOperator are called for all the
different operators. Fixed that with a few #if for the non-shared plugins, but
that doesn't work for the shared plugin. So made the two affected plugins non-
shared for now and left a better fix as a TODO.
Change-Id: I5b87d329ae2c4c93bf605bb1ecc9641039f014a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99000
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/clang/test/implicitboolconversion.cxx')
| -rw-r--r-- | compilerplugins/clang/test/implicitboolconversion.cxx | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/compilerplugins/clang/test/implicitboolconversion.cxx b/compilerplugins/clang/test/implicitboolconversion.cxx index c438822d3b88..31082d1d378b 100644 --- a/compilerplugins/clang/test/implicitboolconversion.cxx +++ b/compilerplugins/clang/test/implicitboolconversion.cxx @@ -11,10 +11,16 @@ #include <atomic> +#include <sal/types.h> + +bool g(); + void f() { // expected-error@+1 {{implicit conversion (IntegralCast) from 'bool' to 'int' [loplugin:implicitboolconversion]}} int i = false; + // expected-error@+1 {{implicit conversion (IntegralCast) from 'bool' to 'int' [loplugin:implicitboolconversion]}} + i = true; (void)i; std::atomic<bool> b = false; (void)b; @@ -23,6 +29,8 @@ void f() // expected-error-re@+1 {{implicit conversion (IntegralCast) from 'bool' to {{.+}} [loplugin:implicitboolconversion]}} std::atomic<int> a = false; (void)a; + bool b2 = true; + b2 &= g(); } /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ |