diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-23 16:07:32 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-27 14:07:56 +0200 |
| commit | c7c6f0af6c836ebe0968967a1e7c8320b0ac17d6 (patch) | |
| tree | 4bc5b2fa623b9765b88bbfe7de10a7590c87d5c8 /compilerplugins/clang/test/stringadd.cxx | |
| parent | 99482297c7dd497e41fad2e7193759043e305101 (diff) | |
loplugin:stringadd convert chained append to +
which can use the more efficient *StringConcat
Also fix a crash in stringview plugin which
started happening while I working on this.
Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/test/stringadd.cxx')
| -rw-r--r-- | compilerplugins/clang/test/stringadd.cxx | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/compilerplugins/clang/test/stringadd.cxx b/compilerplugins/clang/test/stringadd.cxx index a953e44062bb..a18b562a052f 100644 --- a/compilerplugins/clang/test/stringadd.cxx +++ b/compilerplugins/clang/test/stringadd.cxx @@ -217,6 +217,10 @@ void f1(OUString s, OUString t, int i, const char* pChar) // no warning expected OUString c; c = c + OUString(pChar, strlen(pChar), RTL_TEXTENCODING_UTF8); + + OUStringBuffer buf; + // expected-error@+1 {{chained append, rather use single append call and + operator [loplugin:stringadd]}} + buf.append(" ").append(b); } void f2(char ch) { |