diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-27 08:49:39 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-27 09:13:25 +0100 |
commit | 48dc1e48d0fed5e00a3e4b5edf11a90fcc55b5ed (patch) | |
tree | d241315a5658db39879b6c58ca651a0e4469990a /compilerplugins/clang/test | |
parent | 4ca1789e5735e2f2926822562c19e1989c8f5ce2 (diff) |
loplugin:unnecessaryoverride look for more patterns
like
bool Foo::bar() {
b = Super::bar();
return b;
}
Change-Id: I5e4c8005a3da7d7487c9039c35dcbb1d17e65bd7
Reviewed-on: https://gerrit.libreoffice.org/68418
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/test')
-rw-r--r-- | compilerplugins/clang/test/unnecessaryoverride.cxx | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/compilerplugins/clang/test/unnecessaryoverride.cxx b/compilerplugins/clang/test/unnecessaryoverride.cxx index 89b772e04698..f8c210213922 100644 --- a/compilerplugins/clang/test/unnecessaryoverride.cxx +++ b/compilerplugins/clang/test/unnecessaryoverride.cxx @@ -177,4 +177,17 @@ struct Derived5 : public Base5_1, public Base5_2 void f1() { Base5_1::f1(); } // no warning expected }; +struct Base6_1 +{ + bool f1(); +}; +struct Derived6 : public Base6_1 +{ + bool + f1() // expected-error {{public function just calls public parent [loplugin:unnecessaryoverride]}} + { + bool ret = Base6_1::f1(); + return ret; + } +}; /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ |