diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-15 20:24:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-16 07:57:45 +0200 |
| commit | 3ee177a14d8b816ef5b62500aeb54524c289e045 (patch) | |
| tree | 982b524a298c2b2f959f5c858c81be9b3420566a /compilerplugins/clang/test | |
| parent | 820f340f285932bbb8d6739177e9bb81c23c1a5d (diff) | |
loplugin:stringadd look through a couple more known-good methods
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48
Reviewed-on: https://gerrit.libreoffice.org/80855
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/test')
| -rw-r--r-- | compilerplugins/clang/test/stringadd.cxx | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/compilerplugins/clang/test/stringadd.cxx b/compilerplugins/clang/test/stringadd.cxx index c4fe15b16d68..27cc57f1395e 100644 --- a/compilerplugins/clang/test/stringadd.cxx +++ b/compilerplugins/clang/test/stringadd.cxx @@ -19,7 +19,7 @@ namespace test1 { static const char XXX1[] = "xxx"; static const char XXX2[] = "xxx"; -void f(OUString s1, int i, OString o) +void f1(OUString s1, int i, OString o) { OUString s2 = s1; // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}} @@ -41,7 +41,7 @@ void f(OUString s1, int i, OString o) // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}} s2 += OStringToOUString(o, RTL_TEXTENCODING_UTF8); } -void g(OString s1, int i, OUString u) +void f2(OString s1, int i, OUString u) { OString s2 = s1; // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}} @@ -59,6 +59,12 @@ void g(OString s1, int i, OUString u) // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}} s2 += OUStringToOString(u, RTL_TEXTENCODING_ASCII_US); } +void f3(OUString aStr, int nFirstContent) +{ + OUString aFirstStr = aStr.copy(0, nFirstContent); + // expected-error@+1 {{simplify by merging with the preceding assignment [loplugin:stringadd]}} + aFirstStr += "..."; +} } namespace test2 |