diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-14 11:14:08 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-08-16 09:04:51 +0200 |
| commit | 7d7a7862a7dccb6764f80258f28685a0da3cbbcb (patch) | |
| tree | b7281950f84b12c4868542f103a23c1460d22863 /compilerplugins/clang/test | |
| parent | abeab40aeb2bf16c1438b5e5f0cd70b3e11f6b7a (diff) | |
new loplugin:sequenceloop
look for places we should be using std::as_const on for-range
loops over uno::Sequence, to avoid triggering a copy
Change-Id: I7efb641bf09d37c87946f03428ee4eec90298c8a
Reviewed-on: https://gerrit.libreoffice.org/77441
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins/clang/test')
| -rw-r--r-- | compilerplugins/clang/test/sequenceloop.cxx | 35 |
1 files changed, 35 insertions, 0 deletions
diff --git a/compilerplugins/clang/test/sequenceloop.cxx b/compilerplugins/clang/test/sequenceloop.cxx new file mode 100644 index 000000000000..113e8fd588fe --- /dev/null +++ b/compilerplugins/clang/test/sequenceloop.cxx @@ -0,0 +1,35 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include <com/sun/star/uno/Sequence.hxx> +#include <com/sun/star/uno/XInterface.hpp> +#include <utility> + +namespace test1 +{ +void foo(css::uno::Sequence<css::uno::Reference<css::uno::XInterface>>& aSeq) +{ + // expected-error@+1 {{use std::as_const, or make range var const, to avoid creating a copy of the Sequence [loplugin:sequenceloop]}} + for (const auto& x : aSeq) + x.get(); + // no warning expected + for (auto& x : aSeq) + x.get(); + for (const auto& x : std::as_const(aSeq)) + x.get(); +} +// no warning expected +void foo2(const css::uno::Sequence<css::uno::Reference<css::uno::XInterface>>& aSeq) +{ + for (const auto& x : aSeq) + x.get(); +} +}; + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ |