diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2020-08-04 14:51:41 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2020-08-04 18:47:10 +0200 |
commit | 4f294e6976287b936d59035c4fe74ce18d3f132c (patch) | |
tree | 2e3937c09b466d5a9b7ab398bdf23d21a41a0ec3 /compilerplugins/clang/unnecessarycatchthrow.cxx | |
parent | 3e9ce173d5ee46147aeac6820eacfa0a67b1209c (diff) |
Avoid some unhelpful loplugin:makeshared
...like
> canvas/source/directx/dx_impltools.cxx(137,31): error: rather use make_shared than constructing from 'Gdiplus::Graphics *' [loplugin:makeshared]
> GraphicsSharedPtr pRet(Gdiplus::Graphics::FromImage(rBitmap.get()));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
on Windows, where those functions like FromImage are provided by Windows (so we
can't help it that they are returning pointers)
Change-Id: Iae5c4b20d64cc6b38ff66409519fbd25f6e509cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100095
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins/clang/unnecessarycatchthrow.cxx')
0 files changed, 0 insertions, 0 deletions