loplugin:unnecessaryvirtual

Change-Id: Ibacb8bd52f5a9838540a68d238c3ed76eff6571b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170184
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 119 insertions, 31 deletions

diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results
index 65b8bb57a09b..ca225b0b7a04 100644
--- a/compilerplugins/clang/unnecessaryvirtual-dead.results
+++ b/compilerplugins/clang/unnecessaryvirtual-dead.results
@@ -16,10 +16,12 @@ ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:2002
     void std::messages::do_close(int,)const
 ux-gnu/../../../include/c++/13/streambuf:583
     void std::basic_streambuf::imbue(const class std::locale &,)
-vcl/inc/font/LogicalFontInstance.hxx:123
+vcl/inc/font/LogicalFontInstance.hxx:127
     void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,)
 vcl/inc/salframe.hxx:145
     void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
+vcl/inc/salframe.hxx:214
+    void SalFrame::FlashWindow()const
 vcl/inc/salinst.hxx:203
     void SalInstance::releaseMainThread()
 vcl/inc/salinst.hxx:212
diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results
index 3ddcc5fe93be..82bd13690f35 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -1,5 +1,3 @@
-accessibility/inc/standard/vclxaccessiblemenuitem.hxx:44
-    _Bool VCLXAccessibleMenuItem::IsCheckable()
 basic/source/comp/codegen.cxx:478
     void (anonymous namespace)::OffSetAccumulator::start(const unsigned char *,)
 basic/source/comp/codegen.cxx:479
@@ -216,8 +214,6 @@ canvas/inc/rendering/isurface.hxx:34
     void canvas::ISurface::~ISurface()
 chart2/source/inc/WeakListenerAdapter.hxx:52
     void chart::WeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
-codemaker/source/cppumaker/cpputype.cxx:192
-    void (anonymous namespace)::CppuType::dumpEmbindCppFile(class FileStream &,)
 extensions/source/dbpilots/unoautopilot.hxx:81
     class cppu::IPropertyArrayHelper * dbp::OUnoAutoPilot::createArrayHelper()const
 extensions/source/propctrlr/commoncontrol.hxx:129
@@ -234,11 +230,11 @@ extensions/source/propctrlr/commoncontrol.hxx:139
     void pcr::CommonBehaviourControl::notifyModifiedValue()
 extensions/source/propctrlr/commoncontrol.hxx:154
     void pcr::CommonBehaviourControl::disposing()
-forms/source/xforms/datatypes.hxx:217
+forms/source/xforms/datatypes.hxx:215
     class cppu::IPropertyArrayHelper * xforms::ODerivedDataType::createArrayHelper()const
-forms/source/xforms/datatypes.hxx:220
+forms/source/xforms/datatypes.hxx:218
     class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySetInfo> xforms::ODerivedDataType::getPropertySetInfo()
-forms/source/xforms/datatypes.hxx:221
+forms/source/xforms/datatypes.hxx:219
     class cppu::IPropertyArrayHelper & xforms::ODerivedDataType::getInfoHelper()
 forms/source/xforms/namedcollection.hxx:80
     class com::sun::star::uno::Type NamedCollection::getElementType()
@@ -300,12 +296,22 @@ include/vbahelper/vbareturntypes.hxx:38
     void ooo::vba::DefaultReturnHelper::setValue(type-parameter-0-0,)
 include/vbahelper/vbareturntypes.hxx:39
     type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
+include/vcl/BitmapArithmeticBlendFilter.hxx:24
+    void BitmapArithmeticBlendFilter::~BitmapArithmeticBlendFilter()
+include/vcl/BitmapDarkenBlendFilter.hxx:25
+    void BitmapDarkenBlendFilter::~BitmapDarkenBlendFilter()
+include/vcl/BitmapLightenBlendFilter.hxx:25
+    void BitmapLightenBlendFilter::~BitmapLightenBlendFilter()
+include/vcl/BitmapMultiplyBlendFilter.hxx:25
+    void BitmapMultiplyBlendFilter::~BitmapMultiplyBlendFilter()
+include/vcl/BitmapNormalBlendFilter.hxx:25
+    void BitmapNormalBlendFilter::~BitmapNormalBlendFilter()
+include/vcl/BitmapScreenBlendFilter.hxx:25
+    void BitmapScreenBlendFilter::~BitmapScreenBlendFilter()
 include/vcl/customweld.hxx:45
     class rtl::OUString weld::CustomWidgetController::GetHelpText()const
 include/vcl/weld.hxx:109
     void weld::Widget::set_visible(_Bool,)
-sc/inc/patattr.hxx:126
-    _Bool ScPatternAttr::operator==(const class ScPatternAttr &,)const
 sc/source/core/opencl/opbase.hxx:446
     _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const
 sc/source/core/opencl/opbase.hxx:447
@@ -380,6 +386,10 @@ sc/source/ui/vba/vbapagebreak.hxx:47
     void ScVbaPageBreak::Delete()
 sc/source/ui/vba/vbapagebreak.hxx:48
     class com::sun::star::uno::Reference<class ooo::vba::excel::XRange> ScVbaPageBreak::Location()
+sd/source/ui/inc/smarttag.hxx:58
+    _Bool sd::SmartTag::Command(const class CommandEvent &,)
+sd/source/ui/inc/smarttag.hxx:71
+    void sd::SmartTag::select()
 shell/inc/i_xml_parser_event_handler.hxx:41
     void i_xml_parser_event_handler::~i_xml_parser_event_handler()
 slideshow/source/engine/activities/activitiesfactory.cxx:173
@@ -402,8 +412,18 @@ slideshow/source/engine/animationfactory.cxx:620
     void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
 slideshow/source/inc/shape.hxx:221
     void slideshow::internal::Shape::setIsForeground(const _Bool,)
+sw/source/core/inc/txtfrm.hxx:512
+    _Bool SwTextFrame::IsInHyphenatedWord(class SwPaM *,_Bool,)const
+sw/source/writerfilter/dmapper/TableManager.hxx:490
+    void writerfilter::dmapper::TableManager::tableExceptionProps(const class tools::SvRef<class writerfilter::dmapper::TablePropertyMap> &,)
 toolkit/inc/controls/geometrycontrolmodel.hxx:185
     void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,)const
+ux-gnu/../../../include/c++/13/bits/locale_classes.h:780
+    int std::collate::do_compare(const type-parameter-0-0 *,const type-parameter-0-0 *,const type-parameter-0-0 *,const type-parameter-0-0 *,)const
+ux-gnu/../../../include/c++/13/bits/locale_classes.h:794
+    basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > std::collate::do_transform(const type-parameter-0-0 *,const type-parameter-0-0 *,)const
+ux-gnu/../../../include/c++/13/bits/locale_classes.h:807
+    long std::collate::do_hash(const type-parameter-0-0 *,const type-parameter-0-0 *,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:1092
     char std::ctype<char>::do_widen(char,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:1115
@@ -412,12 +432,48 @@ ux-gnu/../../../include/c++/13/bits/locale_facets.h:1142
     char std::ctype<char>::do_narrow(char,char,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:1168
     const char * std::ctype<char>::do_narrow(const char *,const char *,char,char *,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:1831
+    type-parameter-0-0 std::numpunct::do_decimal_point()const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:1843
+    type-parameter-0-0 std::numpunct::do_thousands_sep()const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:1856
+    class std::basic_string<char> std::numpunct::do_grouping()const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:1869
+    basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > std::numpunct::do_truename()const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:1882
+    basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > std::numpunct::do_falsename()const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:2220
     type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,_Bool &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2223
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,long &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2228
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,unsigned short &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2233
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,unsigned int &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2238
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,unsigned long &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2244
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,long long &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2249
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,unsigned long long &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2255
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,float &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2258
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,double &,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2272
+    type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,long double &,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:2277
     type-parameter-0-1 std::num_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,void *&,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:2535
     type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,_Bool,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2538
+    type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,long,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2542
+    type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,unsigned long,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2548
+    type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,long long,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets.h:2553
+    type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,unsigned long long,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets.h:2571
     type-parameter-0-1 std::num_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,const void *,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:636
@@ -434,6 +490,26 @@ ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:730
     type-parameter-0-1 std::time_get::do_get_year(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:755
     type-parameter-0-1 std::time_get::do_get(type-parameter-0-1,type-parameter-0-1,class std::ios_base &,enum std::_Ios_Iostate &,struct tm *,char,char,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:922
+    type-parameter-0-1 std::time_put::do_put(type-parameter-0-1,class std::ios_base &,type-parameter-0-0,const struct tm *,char,char,)const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1297
+    type-parameter-0-0 std::moneypunct::do_decimal_point()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1309
+    type-parameter-0-0 std::moneypunct::do_thousands_sep()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1322
+    class std::basic_string<char> std::moneypunct::do_grouping()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1335
+    basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > std::moneypunct::do_curr_symbol()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1348
+    basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > std::moneypunct::do_positive_sign()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1361
+    basic_string<type-parameter-0-0, char_traits<type-parameter-0-0>, allocator<type-parameter-0-0> > std::moneypunct::do_negative_sign()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1375
+    int std::moneypunct::do_frac_digits()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1389
+    struct std::money_base::pattern std::moneypunct::do_pos_format()const
+ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1403
+    struct std::money_base::pattern std::moneypunct::do_neg_format()const
 ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1613
     type-parameter-0-1 std::money_get::do_get(type-parameter-0-1,type-parameter-0-1,_Bool,class std::ios_base &,enum std::_Ios_Iostate &,long double &,)const
 ux-gnu/../../../include/c++/13/bits/locale_facets_nonio.h:1625
@@ -518,43 +594,53 @@ ux-gnu/../../../include/c++/13/sstream:401
     typename type-parameter-0-1::pos_type std::basic_stringbuf::seekpos(typename type-parameter-0-1::pos_type,enum std::_Ios_Openmode,)
 ux-gnu/../../../include/c++/13/streambuf:583
     void std::basic_streambuf::imbue(const class std::locale &,)
+ux-gnu/../../../include/c++/13/streambuf:598
+    basic_streambuf<_CharT, _Traits> * std::basic_streambuf::setbuf(type-parameter-0-0 *,long,)
+ux-gnu/../../../include/c++/13/streambuf:609
+    typename type-parameter-0-1::pos_type std::basic_streambuf::seekoff(typename type-parameter-0-1::off_type,enum std::_Ios_Seekdir,enum std::_Ios_Openmode,)
+ux-gnu/../../../include/c++/13/streambuf:621
+    typename type-parameter-0-1::pos_type std::basic_streambuf::seekpos(typename type-parameter-0-1::pos_type,enum std::_Ios_Openmode,)
 ux-gnu/../../../include/c++/13/streambuf:634
     int std::basic_streambuf::sync()
+ux-gnu/../../../include/c++/13/streambuf:656
+    long std::basic_streambuf::showmanyc()
 ux-gnu/../../../include/c++/13/streambuf:672
     long std::basic_streambuf::xsgetn(type-parameter-0-0 *,long,)
+ux-gnu/../../../include/c++/13/streambuf:694
+    typename type-parameter-0-1::int_type std::basic_streambuf::underflow()
 ux-gnu/../../../include/c++/13/streambuf:707
     typename type-parameter-0-1::int_type std::basic_streambuf::uflow()
+ux-gnu/../../../include/c++/13/streambuf:731
+    typename type-parameter-0-1::int_type std::basic_streambuf::pbackfail(typename type-parameter-0-1::int_type,)
 ux-gnu/../../../include/c++/13/streambuf:749
     long std::basic_streambuf::xsputn(const type-parameter-0-0 *,long,)
+ux-gnu/../../../include/c++/13/streambuf:775
+    typename type-parameter-0-1::int_type std::basic_streambuf::overflow(typename type-parameter-0-1::int_type,)
 ux-gnu/qt5/QtGui/qpaintdevice.h:74
     int QPaintDevice::devType()const
-vcl/inc/font/LogicalFontInstance.hxx:123
+vcl/inc/font/LogicalFontInstance.hxx:127
     void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,)
 vcl/inc/jsdialog/jsdialogbuilder.hxx:161
     void JSDialogSender::sendFullUpdate(_Bool,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:164
-    void JSDialogSender::sendAction(const class VclPtr<class vcl::Window> &,class std::unique_ptr<class std::unordered_map<class rtl::OString, class rtl::OUString> >,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:166
-    void JSDialogSender::sendPopup(const class VclPtr<class vcl::Window> &,const class rtl::OUString &,const class rtl::OUString &,)
 vcl/inc/jsdialog/jsdialogbuilder.hxx:168
     void JSDialogSender::sendClosePopup(unsigned int,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:393
+vcl/inc/jsdialog/jsdialogbuilder.hxx:394
     void JSWidget::show()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:406
+vcl/inc/jsdialog/jsdialogbuilder.hxx:407
     void JSWidget::hide()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:420
+vcl/inc/jsdialog/jsdialogbuilder.hxx:421
     void JSWidget::set_sensitive(_Bool,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:428
+vcl/inc/jsdialog/jsdialogbuilder.hxx:434
     class com::sun::star::uno::Reference<class com::sun::star::datatransfer::dnd::XDropTarget> JSWidget::get_drop_target()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:436
-    void JSWidget::freeze()
 vcl/inc/jsdialog/jsdialogbuilder.hxx:442
+    void JSWidget::freeze()
+vcl/inc/jsdialog/jsdialogbuilder.hxx:448
     void JSWidget::thaw()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:449
+vcl/inc/jsdialog/jsdialogbuilder.hxx:455
     void JSWidget::grab_focus()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:494
+vcl/inc/jsdialog/jsdialogbuilder.hxx:500
     void JSWidget::set_buildable_name(const class rtl::OUString &,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:622
+vcl/inc/jsdialog/jsdialogbuilder.hxx:630
     void JSComboBox::set_entry_text_without_notify(const class rtl::OUString &,)
 vcl/inc/qt5/QtFrame.hxx:160
     void QtFrame::registerDragSource(class QtDragSource *,)
@@ -568,6 +654,8 @@ vcl/inc/salframe.hxx:145
     void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
 vcl/inc/salframe.hxx:194
     void SalFrame::Flush(const class tools::Rectangle &,)
+vcl/inc/salframe.hxx:214
+    void SalFrame::FlashWindow()const
 vcl/inc/salinst.hxx:95
     _Bool SalInstance::SVMainHook(int *,)
 vcl/inc/salinst.hxx:203
@@ -576,15 +664,15 @@ vcl/inc/salinst.hxx:212
     void SalInstance::BeforeAbort(const class rtl::OUString &,_Bool,)
 vcl/inc/salobj.hxx:49
     void SalObject::Enable(_Bool,)
-vcl/inc/salprn.hxx:119
+vcl/inc/salprn.hxx:124
     enum SalPrinterError SalPrinter::GetErrorCode()
-vcl/inc/skia/gdiimpl.hxx:231
+vcl/inc/skia/gdiimpl.hxx:230
     void SkiaSalGraphicsImpl::createSurface()
-vcl/inc/skia/gdiimpl.hxx:241
+vcl/inc/skia/gdiimpl.hxx:240
     void SkiaSalGraphicsImpl::flushSurfaceToWindowContext()
-vcl/inc/skia/gdiimpl.hxx:264
+vcl/inc/skia/gdiimpl.hxx:263
     int SkiaSalGraphicsImpl::getWindowScaling()const
-vcl/inc/unx/gtk/gtkdata.hxx:336
+vcl/inc/unx/gtk/gtkdata.hxx:332
     int GtkSalDisplay::CaptureMouse(class SalFrame *,)
 vcl/inc/unx/saldata.hxx:48
     void X11SalData::Init()
@@ -594,8 +682,6 @@ vcl/inc/unx/salframe.h:208
     void X11SalFrame::updateGraphics(_Bool,)
 vcl/inc/unx/salinst.h:39
     class SalX11Display * X11SalInstance::CreateDisplay()const
-writerfilter/source/dmapper/TableManager.hxx:490
-    void writerfilter::dmapper::TableManager::tableExceptionProps(const class tools::SvRef<class writerfilter::dmapper::TablePropertyMap> &,)
 xmloff/source/forms/elementimport.hxx:548
     class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySet> xmloff::OColumnImport::createElement()