diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-15 11:24:43 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-09-15 11:30:42 +0200 |
commit | 3b48b3cc92c93911f61535d22a2c8731574ee51a (patch) | |
tree | 2602c98df9d414d803e94bf9f80780d4395b8d8f /compilerplugins | |
parent | b79b5e0df6dc5a0ba18054b0503d6fa804b69f02 (diff) |
loplugin:singlevalfields in sc..vcl
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
Diffstat (limited to 'compilerplugins')
-rwxr-xr-x | compilerplugins/clang/singlevalfields.py | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/compilerplugins/clang/singlevalfields.py b/compilerplugins/clang/singlevalfields.py index 47c4c0d806c1..403ccbcd03d7 100755 --- a/compilerplugins/clang/singlevalfields.py +++ b/compilerplugins/clang/singlevalfields.py @@ -38,15 +38,18 @@ for fieldInfo, assignValues in fieldAssignDict.iteritems(): continue if "?" in assignValues: continue - # if it contains anything other than this set, ignore it - if len(assignValues - set(["0", "1", "-1", "nullptr"])) > 0: - continue + #if len(assignValues - set(["0", "1", "-1", "nullptr"])) > 0: + # continue # ignore things which are locally declared but are actually redeclarations of things from 3rd party code - parentClass = fieldInfo[0] - if parentClass == "_mwmhints": + containingClass = fieldInfo[0] + if containingClass == "_mwmhints": continue # ignore things which are representations of on-disk structures - if parentClass in ["SEPr", "WW8Dop", ]: + if containingClass in ["SEPr", "WW8Dop", "BmpInfoHeader", "BmpFileHeader", "Exif::ExifIFD", + "sw::WW8FFData", "FFDataHeader", "INetURLHistory_Impl::head_entry"]: + continue + # Windows-only + if containingClass in ["SfxAppData_Impl", "sfx2::ImplDdeItem"]: continue v0 = fieldInfo[0] + " " + fieldInfo[1] v1 = (",".join(assignValues)) |