remove loplugin:finalprotected

It just forces a custom rule that serves no real purpose. There's
no technical difference. If one day a class gets inherited from
then this information will be lost/incorrect. And mixing access
on a virtual function is poor style.

Change-Id: I0c27db8d694ad191a118d4e1d3d4a240e00456fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125337
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

2 files changed, 0 insertions, 35 deletions

diff --git a/compilerplugins/clang/finalprotected.cxx b/compilerplugins/clang/store/finalprotected.cxx
index 41b994c049d5..41b994c049d5 100644
--- a/compilerplugins/clang/finalprotected.cxx
+++ b/compilerplugins/clang/store/finalprotected.cxx
diff --git a/compilerplugins/clang/test/finalprotected.cxx b/compilerplugins/clang/test/finalprotected.cxx
deleted file mode 100644
index c15564874447..000000000000
--- a/compilerplugins/clang/test/finalprotected.cxx
+++ /dev/null
@@ -1,35 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-
-class S final {
-protected:
-    void f(int f) { f1 = f; }  // expected-error {{final class should not have protected members - convert them to private [loplugin:finalprotected]}}
-    int f1;      // expected-error {{final class should not have protected members - convert them to private [loplugin:finalprotected]}}
-public:
-    void g();
-    int g1;
-private:
-    void h();
-    int h1;
-};
-
-class S2 {
-protected:
-    void f(int f) { f1 = f; }
-    int f1;
-public:
-    void g();
-    int g1;
-private:
-    void h();
-    int h1;
-};
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */