diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-17 09:27:41 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-17 10:13:47 +0200 |
| commit | 6e1cb2e9dd406fb2883460cefaa4660622996005 (patch) | |
| tree | f05a00e0fd7fc131a0fcc908b35bceecdc2b1311 /compilerplugins | |
| parent | 573562e72a5fd85b75006fbc8869c73903a6e504 (diff) | |
disable stringbuffer plugin
as pointed out by mike kaganski:
the 'aCellStr + u"\x0001"' expression gives an OUStringConcat which
holds the references to the strings and doesn't allocate any memory; the
OUStringBuffer has a dedicated overload of append() for the
OUStringConcat, which allocates only once for the combined concat length
and then copies everything from the concat, instead of doing the append
twice for each element... why the strange warning for a more efficient
method?
Change-Id: I6492e99c335e2375cfe78547a87b3079a86890f0
Reviewed-on: https://gerrit.libreoffice.org/79036
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/stringbuffer.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compilerplugins/clang/stringbuffer.cxx b/compilerplugins/clang/stringbuffer.cxx index ad8b2eb792a0..b68a8ba32700 100644 --- a/compilerplugins/clang/stringbuffer.cxx +++ b/compilerplugins/clang/stringbuffer.cxx @@ -66,7 +66,7 @@ bool StringBuffer::VisitCXXMemberCallExpr(CXXMemberCallExpr const* memberCallExp return true; } -loplugin::Plugin::Registration<StringBuffer> stringbuffer("stringbuffer"); +loplugin::Plugin::Registration<StringBuffer> stringbuffer("stringbuffer", false); } // namespace |