summaryrefslogtreecommitdiff
path: root/compilerplugins
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-03-03 11:27:32 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-03-03 11:09:46 +0000
commit2675f26f1a155257bd1680a1e1a1ba58da8c4452 (patch)
tree5227b9c07962e01d64419898833d8418c3d4f9e0 /compilerplugins
parentf210499af1a6889785d49f8881672324afc755c1 (diff)
remove unused CreateDefault methods
Change-Id: Ifbdd7d41f0938e9a03693f88416792ff8087f8c2 Reviewed-on: https://gerrit.libreoffice.org/34850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
-rwxr-xr-xcompilerplugins/clang/unusedmethods.py8
1 files changed, 1 insertions, 7 deletions
diff --git a/compilerplugins/clang/unusedmethods.py b/compilerplugins/clang/unusedmethods.py
index c164b6ee62db..d8db1c4bcdac 100755
--- a/compilerplugins/clang/unusedmethods.py
+++ b/compilerplugins/clang/unusedmethods.py
@@ -197,7 +197,7 @@ for d in definitionSet:
continue
if isOtherConstness(d, callSet):
continue
- # include assignment operators, if we remove them, the compiler creates a default one, which can have odd consequences
+ # exclude assignment operators, if we remove them, the compiler creates a default one, which can have odd consequences
if "::operator=(" in d[1]:
continue
# these are only invoked implicitly, so the plugin does not see the calls
@@ -245,9 +245,6 @@ for d in definitionSet:
continue
if d[0] == "basic_ostream<type-parameter-?-?, type-parameter-?-?> &" and d[1].startswith("operator<<(basic_ostream<type-parameter-?-?"):
continue
- # ignore the SfxPoolItem CreateDefault methods for now
- if d[1].endswith("::CreateDefault()"):
- continue
if "::operator" in d[1]:
continue
@@ -302,9 +299,6 @@ for d in definitionSet:
# ignore external code
if definitionToSourceLocationMap[d].startswith("external/"):
continue
- # ignore the SfxPoolItem CreateDefault methods for now
- if d[1].endswith("::CreateDefault()"):
- continue
# ignore UNO constructor functions
if (d[0] == "class com::sun::star::uno::Reference<class com::sun::star::uno::XInterface>" and
d[1].endswith("_createInstance(const class com::sun::star::uno::Reference<class com::sun::star::lang::XMultiServiceFactory> &)")):