summaryrefslogtreecommitdiff
path: root/compilerplugins
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2020-02-03 17:01:05 +0100
committerStephan Bergmann <sbergman@redhat.com>2020-02-03 23:45:46 +0100
commit9aa2b6b7a91c17658e7fc14e11809f746dcd440f (patch)
tree54600593b52241d82dc17ef426d22969b200c44b /compilerplugins
parent93d836b6737d0653bf0a86e93bd711c0706c9d9b (diff)
Silence loplugin:unnecessaryoverride in WinSalInstance::GetBackendCapabilities
...(vcl/win/app/salinst.cxx) in case the #if HAVE_FEATURE_SKIA #if SKIA_USE_BITMAP32 ... block it contains is excluded (when building with clang-cl on Windows) Change-Id: I60910106bbd6a4c2cb3f393945a5417eb02407c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87898 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
-rw-r--r--compilerplugins/clang/unnecessaryoverride.cxx4
1 files changed, 4 insertions, 0 deletions
diff --git a/compilerplugins/clang/unnecessaryoverride.cxx b/compilerplugins/clang/unnecessaryoverride.cxx
index 1ad521a17571..10ab158b7d8d 100644
--- a/compilerplugins/clang/unnecessaryoverride.cxx
+++ b/compilerplugins/clang/unnecessaryoverride.cxx
@@ -380,6 +380,10 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const CXXMethodDecl* methodDecl)
return true;
}
+ if (containsPreprocessingConditionalInclusion(methodDecl->getBody()->getSourceRange())) {
+ return true;
+ }
+
report(
DiagnosticsEngine::Warning, "%0%1 function just calls %2 parent",
methodDecl->getLocation())