diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-02 08:58:19 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-03 08:38:50 +0200 |
| commit | 4450b2a16677431b1b9dfaa28d0b9af9e51ebdec (patch) | |
| tree | 22aa13a8d13f690b8498ec4bdb502d198593fcab /compilerplugins | |
| parent | d76281864b0e83812c0edf7490b1e8271e89fff5 (diff) | |
pass area param to DBG_UNHANDLED_EXCEPTION
and update sallogareas plugin to enforce this
Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a
Reviewed-on: https://gerrit.libreoffice.org/52249
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/sallogareas.cxx | 2 | ||||
| -rw-r--r-- | compilerplugins/clang/test/sallogareas.cxx | 2 |
2 files changed, 1 insertions, 3 deletions
diff --git a/compilerplugins/clang/sallogareas.cxx b/compilerplugins/clang/sallogareas.cxx index 1095302d9ada..e31754493523 100644 --- a/compilerplugins/clang/sallogareas.cxx +++ b/compilerplugins/clang/sallogareas.cxx @@ -93,8 +93,6 @@ bool SalLogAreas::VisitCallExpr( const CallExpr* call ) area->getLocStart()); return true; } - if( kind == LogCallKind::DbgUnhandledException ) // below checks don't apply - return true; if( loplugin::DeclCheck(inFunction).Function("log").Namespace("detail").Namespace("sal").GlobalNamespace() || loplugin::DeclCheck(inFunction).Function("sal_detail_logFormat").GlobalNamespace() ) return true; // These functions only forward to sal_detail_log, so ok. diff --git a/compilerplugins/clang/test/sallogareas.cxx b/compilerplugins/clang/test/sallogareas.cxx index 6a9035a05f30..eb3f1a70fa2f 100644 --- a/compilerplugins/clang/test/sallogareas.cxx +++ b/compilerplugins/clang/test/sallogareas.cxx @@ -51,7 +51,7 @@ int main() } catch (std::exception const&) { - DBG_UNHANDLED_EXCEPTION(); + DBG_UNHANDLED_EXCEPTION(); // expected-error {{missing log area [loplugin:sallogareas]}} } } |