diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-02-24 11:22:18 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-02-28 10:17:47 +0000 |
commit | 198c41c4fe8be4ce8a6ddab43ae0c5f17a4889ac (patch) | |
tree | 041d55126e9770b81f68fadfaaa69e82313786b3 /compilerplugins | |
parent | d3981b3e8c021ee03a2ca7103a73e56cca18df81 (diff) |
new loplugin unoany
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
-rw-r--r-- | compilerplugins/clang/test/unoany.cxx | 27 | ||||
-rw-r--r-- | compilerplugins/clang/unoany.cxx | 74 |
2 files changed, 101 insertions, 0 deletions
diff --git a/compilerplugins/clang/test/unoany.cxx b/compilerplugins/clang/test/unoany.cxx new file mode 100644 index 000000000000..8c7ba7e90179 --- /dev/null +++ b/compilerplugins/clang/test/unoany.cxx @@ -0,0 +1,27 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include "sal/config.h" + +#include "com/sun/star/uno/Any.hxx" + +css::uno::Any getAny() { return css::uno::Any(true); } + +int main() +{ + css::uno::Any a; + css::uno::Any b; + a = b; + a = getAny(); + a = css::uno::makeAny(true); // expected-error {{unnecessary copy, rather use <<= operator [loplugin:unoany]}} + a = css::uno::Any(true); // expected-error {{unnecessary copy, rather use <<= operator [loplugin:unoany]}} +} + + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/compilerplugins/clang/unoany.cxx b/compilerplugins/clang/unoany.cxx new file mode 100644 index 000000000000..6fdf3b45d94f --- /dev/null +++ b/compilerplugins/clang/unoany.cxx @@ -0,0 +1,74 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include "check.hxx" +#include "plugin.hxx" + + +class UnoAny: + public RecursiveASTVisitor<UnoAny>, public loplugin::Plugin +{ +public: + explicit UnoAny(InstantiationData const & data): Plugin(data) {} + + void run() override { + TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); + } + bool VisitCXXOperatorCallExpr(CXXOperatorCallExpr const * expr); +}; + +bool UnoAny::VisitCXXOperatorCallExpr(CXXOperatorCallExpr const * expr) +{ + if (ignoreLocation(expr)) { + return true; + } + StringRef aFileName = compiler.getSourceManager().getFilename(compiler.getSourceManager().getSpellingLoc(expr->getLocStart())); + if (aFileName == SRCDIR "/include/com/sun/star/uno/Any.hxx") { + return true; + } + if (expr->getOperator() != OO_Equal) { + return true; + } + if (!loplugin::TypeCheck(expr->getArg(0)->getType()).Class("Any"). + Namespace("uno").Namespace("star").Namespace("sun").Namespace("com").GlobalNamespace()) + { + return true; + } + if (auto expr2 = dyn_cast<MaterializeTemporaryExpr>(expr->getArg(1))) { + if (auto expr3 = dyn_cast<CXXBindTemporaryExpr>(expr2->GetTemporaryExpr())) { + if (auto expr4 = dyn_cast<CallExpr>(expr3->getSubExpr())) { + if (loplugin::DeclCheck(expr4->getDirectCallee()).Function("makeAny"). + Namespace("uno").Namespace("star").Namespace("sun").Namespace("com").GlobalNamespace()) { + report( + DiagnosticsEngine::Warning, + "unnecessary copy, rather use <<= operator", + expr->getOperatorLoc()) + << expr->getSourceRange(); + return true; + } + } + } + if (isa<CXXFunctionalCastExpr>(expr2->GetTemporaryExpr())) { + //expr->getArg(1)->dump(); + report( + DiagnosticsEngine::Warning, + "unnecessary copy, rather use <<= operator", + expr->getOperatorLoc()) + << expr->getSourceRange(); + return true; + } + } + //expr->getArg(1)->dump(); + return true; +} + +loplugin::Plugin::Registration<UnoAny> X("unoany"); + + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ |