diff options
| author | Jan Holesovsky <kendy@collabora.com> | 2017-11-29 14:19:54 +0100 |
|---|---|---|
| committer | Jan Holesovsky <kendy@collabora.com> | 2017-12-05 15:07:44 +0100 |
| commit | 8ce967ad157d83ad567c5f8c750f4225dd974219 (patch) | |
| tree | c42db1a2efd60be76c84b0d0b600ccde1f231490 /compilerplugins | |
| parent | 2326619cba28dcbe54063baffd6094f037230c88 (diff) | |
lokdialog: Make the badstatic loplugin happy.
Change-Id: Ic19bbd2a3533e4e600d8856e55c4e8d06f0ad752
Reviewed-on: https://gerrit.libreoffice.org/45500
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/badstatics.cxx | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/compilerplugins/clang/badstatics.cxx b/compilerplugins/clang/badstatics.cxx index 17cbb0d8e2ba..bf3f4be4b66f 100644 --- a/compilerplugins/clang/badstatics.cxx +++ b/compilerplugins/clang/badstatics.cxx @@ -202,6 +202,7 @@ public: || name == "m_aUncommitedRegistrations" // sw/source/uibase/dbui/dbmgr.cxx || (loplugin::DeclCheck(pVarDecl).Var("aAllListeners") .Class("ScAddInListener").GlobalNamespace()) // not owning + || name == "s_pLOKWindowsMap" // LOK only, guarded by assert, and LOK never tries to perform a VCL cleanup ) // these variables appear unproblematic { return true; @@ -213,12 +214,6 @@ public: { return true; } - //TODO: Ignore for now to unbreak the build post - // d516c5c9819dcd7dc6dded2f8f9d9e44061b23c0 "lokdialog: Move the LOKWindowId <-> - // VclPtr<Window> mapping to Window": - if (name == "sLOKWindows") { // vcl/source/window/window.cxx - return true; - } // ignore pointers, nothing happens to them on shutdown QualType const pCanonical(pVarDecl->getType().getUnqualifiedType().getCanonicalType()); if (pCanonical->isPointerType()) { |