diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-10-21 19:27:12 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-10-22 07:18:49 +0200 |
| commit | 20c6dfde1dff22de7d38ecea00bcf75aa21a1694 (patch) | |
| tree | 0f47a0c02c5ae5d1efd7cba59abf2256fc4e990d /compilerplugins | |
| parent | 2008880a57754c5e54625b06fb9a1a23a848a617 (diff) | |
There doesn't need to be a TemplateSpecializationType here
On both macOS (libc++) and Windows (MSVC standard library),
compilerplugins/clang/test/getstr.cxx failed four tests without this fix:
> error: 'error' diagnostics expected but not seen:
> File compilerplugins/clang/test/getstr.cxx Line 29: suspicious use of 'getStr' on an object of type 'rtl::OUStringBuffer'; the result is implicitly cast to a void pointer in a call of 'operator <<' [loplugin:getstr]
> File compilerplugins/clang/test/getstr.cxx Line 30: directly use object of type 'S' (aka 'rtl::OString') in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
> File compilerplugins/clang/test/getstr.cxx Line 34: suspicious use of 'getStr' on an object of type 'rtl::OUStringBuffer'; the result is implicitly cast to a void pointer in a call of 'operator <<' [loplugin:getstr]
> File compilerplugins/clang/test/getstr.cxx Line 35: directly use object of type 'rtl::OString' in a call of 'operator <<', instead of calling 'getStr' first [loplugin:getstr]
Change-Id: I65406d3d84bb5a89df44c8fd665b6e38d19f38c7
Reviewed-on: https://gerrit.libreoffice.org/81266
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/getstr.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/compilerplugins/clang/getstr.cxx b/compilerplugins/clang/getstr.cxx index 15f340296bea..aba53bd6e2e5 100644 --- a/compilerplugins/clang/getstr.cxx +++ b/compilerplugins/clang/getstr.cxx @@ -70,7 +70,6 @@ public: } assert(expr->getNumArgs() == 2); if (!loplugin::TypeCheck(expr->getArg(0)->getType()) - .TemplateSpecializationClass() .ClassOrStruct("basic_ostream") .StdNamespace()) //TODO: check template args { |