diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2021-04-29 12:00:25 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2021-05-03 11:23:34 +0200 |
commit | 0d18b90b75c074c0cca4d12a6468f2397909b886 (patch) | |
tree | bc040ca65166cb574efc9ae51c8e1606aab44f5b /compilerplugins | |
parent | d417d25f417cc79b480bdfa4b2776562ee10f8c1 (diff) |
throw() -> noexcept, part 3/3: New loplugin:noexcept
Change-Id: I3ce3fab3e8047be14e003f1f3096b4e2745534e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115026
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
-rw-r--r-- | compilerplugins/clang/noexcept.cxx | 82 | ||||
-rw-r--r-- | compilerplugins/clang/test/noexcept.cxx | 16 |
2 files changed, 98 insertions, 0 deletions
diff --git a/compilerplugins/clang/noexcept.cxx b/compilerplugins/clang/noexcept.cxx new file mode 100644 index 000000000000..ae0bfdf95207 --- /dev/null +++ b/compilerplugins/clang/noexcept.cxx @@ -0,0 +1,82 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include "plugin.hxx" + +namespace +{ +class Noexcept : public loplugin::FilteringRewritePlugin<Noexcept> +{ +public: + explicit Noexcept(loplugin::InstantiationData const& data) + : FilteringRewritePlugin(data) + { + } + + void run() override + { + // Don't execute for < C++11, so we don't accidentally rewrite the legacy definitions of + // SAL_THROW_EXTERN_C and SAL_NOEXCEPT in include/sal/types.h e.g. when building + // CppunitTest_odk_checkapi which explicitly uses gb_CXX03FLAGS: + if (compiler.getLangOpts().CPlusPlus11) + { + TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); + } + } + + bool VisitFunctionProtoTypeLoc(FunctionProtoTypeLoc tloc) + { + if (ignoreLocation(tloc)) + { + return true; + } + if (tloc.getTypePtr()->getExceptionSpecType() != EST_DynamicNone) + { + return true; + } + auto const r = tloc.getExceptionSpecRange(); + auto const repl = isInUnoIncludeFile(r.getBegin()) ? "SAL_NOEXCEPT" : "noexcept"; + if (rewriter != nullptr) + { + auto r2 = r; + auto l1 = r.getBegin(); + while (compiler.getSourceManager().isMacroArgExpansion(l1)) + { + l1 = compiler.getSourceManager().getImmediateMacroCallerLoc(l1); + } + if (compiler.getSourceManager().isMacroBodyExpansion(l1)) + { + auto l2 = r.getEnd(); + while (compiler.getSourceManager().isMacroArgExpansion(l2)) + { + l2 = compiler.getSourceManager().getImmediateMacroCallerLoc(l2); + } + if (compiler.getSourceManager().isMacroBodyExpansion(l2)) + { + //TODO: check l1, l2 are in same macro body expansion + r2 = { compiler.getSourceManager().getSpellingLoc(l1), + compiler.getSourceManager().getSpellingLoc(l2) }; + } + } + if (replaceText(r2, repl)) + { + return true; + } + } + report(DiagnosticsEngine::Warning, + "Replace legacy dynamic 'throw ()' exception specification with '%0'", r.getBegin()) + << repl << r; + return true; + } +}; + +loplugin::Plugin::Registration<Noexcept> X("noexcept", true); +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/compilerplugins/clang/test/noexcept.cxx b/compilerplugins/clang/test/noexcept.cxx new file mode 100644 index 000000000000..f46a3d87f2b7 --- /dev/null +++ b/compilerplugins/clang/test/noexcept.cxx @@ -0,0 +1,16 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +// expected-error@+1 {{Replace legacy dynamic 'throw ()' exception specification with 'noexcept' [loplugin:noexcept]}} +void f() throw(); + +// expected-error@+1 {{Replace legacy dynamic 'throw ()' exception specification with 'noexcept' [loplugin:noexcept]}} +using F = void() throw(); + +/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ |