loplugin:unusedfields

Change-Id: Idf6f7f2946eecada64d2a586194533840ec8cc63
Reviewed-on: https://gerrit.libreoffice.org/61248
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 48 insertions, 70 deletions

diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index d0af141ef3a7..0edd134d5367 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -120,7 +120,7 @@ cppu/source/uno/check.cxx:138
     (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
 cui/source/dialogs/colorpicker.cxx:719
     cui::ColorPickerDialog m_aColorPrevious class cui::ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1398
+cui/source/factory/dlgfact.cxx:1418
     SvxMacroAssignDialog m_aItems class SfxItemSet
 cui/source/inc/cfgutil.hxx:190
     SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl
@@ -162,7 +162,7 @@ drawinglayer/source/tools/emfphelperdata.hxx:155
     emfplushelper::EmfPlusHelperData mnFrameRight sal_Int32
 drawinglayer/source/tools/emfphelperdata.hxx:156
     emfplushelper::EmfPlusHelperData mnFrameBottom sal_Int32
-editeng/source/editeng/impedit.hxx:462
+editeng/source/editeng/impedit.hxx:460
     ImpEditEngine aSelFuncSet class EditSelFunctionSet
 filter/source/flash/swfwriter.hxx:391
     swf::Writer maMovieTempFile utl::TempFile
@@ -352,16 +352,8 @@ sc/source/filter/xml/xmltransformationi.hxx:121
     ScXMLColumnNumberContext aType class rtl::OUString
 sc/source/filter/xml/xmltransformationi.hxx:155
     ScXMLDateTimeContext aType class rtl::OUString
-sc/source/ui/Accessibility/AccessibleText.cxx:52
-    ScViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:273
-    ScPreviewCellViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:289
-    ScPreviewHeaderCellViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:305
-    ScPreviewNoteViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:1309
-    ScCsvViewForwarder maBoundBox tools::Rectangle
+sc/source/ui/dataprovider/sqldataprovider.cxx:41
+    sc::SQLFetchThread maURL class rtl::OUString
 sc/source/ui/inc/acredlin.hxx:58
     ScAcceptChgDlg aReOpenIdle class Idle
 sc/source/ui/inc/anyrefdg.hxx:119
@@ -547,7 +539,7 @@ sw/source/uibase/inc/uivwimp.hxx:95
 sw/source/uibase/inc/unodispatch.hxx:46
     SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard
 toolkit/source/awt/stylesettings.cxx:90
-    toolkit::StyleMethodGuard m_aGuard class SolarMutexGuard
+    toolkit::StyleMethodGuard m_aGuard const class SolarMutexGuard
 ucb/source/ucp/gio/gio_mount.hxx:46
     OOoMountOperationClass parent_class GMountOperationClass
 ucb/source/ucp/gio/gio_mount.hxx:49
@@ -592,20 +584,20 @@ vcl/inc/unx/i18n_ic.hxx:46
     SalI18N_InputContext maSwitchIMCallback XIMCallback
 vcl/inc/unx/i18n_ic.hxx:47
     SalI18N_InputContext maDestroyCallback XIMCallback
-vcl/source/app/salvtables.cxx:1462
+vcl/source/app/salvtables.cxx:1504
     SalInstanceEntry m_aTextFilter class SalInstanceEntry::WeldTextFilter
 vcl/source/gdi/jobset.cxx:35
     ImplOldJobSetupData cDeviceName char [32]
 vcl/source/gdi/jobset.cxx:36
     ImplOldJobSetupData cPortName char [32]
-vcl/unx/gtk3/gtk3gtkinst.cxx:2255
+vcl/unx/gtk3/gtk3gtkinst.cxx:2267
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link const AtkHyperlink
 vcl/unx/gtk/a11y/atkwrapper.hxx:49
     AtkObjectWrapper aParent const AtkObject
-vcl/unx/gtk/a11y/atkwrapper.hxx:78
-    AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
+vcl/unx/gtk/a11y/atkwrapper.hxx:80
+    AtkObjectWrapperClass aParentClass const AtkObjectClass
 vcl/unx/gtk/gloactiongroup.cxx:30
     GLOAction parent_instance GObject
 vcl/unx/gtk/glomenu.cxx:20
diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results
index 940c24fe2ed0..45c7a8293aeb 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -158,11 +158,11 @@ cui/source/options/optcolor.cxx:255
     ColorConfigWindow_Impl aModuleOptions class SvtModuleOptions
 cui/source/options/optpath.cxx:79
     OptPath_Impl m_aDefOpt class SvtDefaultOptions
-cui/source/options/personalization.hxx:38
-    SvxPersonalizationTabPage m_vDefaultPersonaImages VclPtr<class PushButton> [6]
-cui/source/options/personalization.hxx:102
-    SelectPersonaDialog m_vResultList VclPtr<class PushButton> [9]
+cui/source/options/personalization.hxx:39
+    SvxPersonalizationTabPage m_vDefaultPersonaImages VclPtr<class PushButton> [3]
 cui/source/options/personalization.hxx:103
+    SelectPersonaDialog m_vResultList VclPtr<class PushButton> [9]
+cui/source/options/personalization.hxx:104
     SelectPersonaDialog m_vSearchSuggestions VclPtr<class PushButton> [6]
 cui/source/options/treeopt.cxx:469
     OptionsGroupInfo m_bLoadError _Bool
@@ -298,12 +298,6 @@ include/registry/refltype.hxx:69
     RTUik m_Data5 sal_uInt32
 include/sfx2/charmapcontrol.hxx:44
     SfxCharmapCtrl m_pFavCharView VclPtr<class SvxCharViewControl> [16]
-include/sfx2/itemconnect.hxx:234
-    sfx::ItemControlConnection maItemWrp sfx::ItemControlConnection::ItemWrapperType
-include/sfx2/itemconnect.hxx:235
-    sfx::ItemControlConnection mxCtrlWrp std::unique_ptr<ControlWrpT>
-include/sfx2/itemwrapper.hxx:115
-    sfx::SingleItemWrapper mnSlot sal_uInt16
 include/sfx2/msg.hxx:95
     SfxTypeAttrib nAID sal_uInt16
 include/sfx2/msg.hxx:96
@@ -358,27 +352,27 @@ include/test/sheet/xnamedranges.hxx:38
     apitest::XNamedRanges xSheet css::uno::Reference<css::sheet::XSpreadsheet>
 include/test/sheet/xspreadsheets2.hxx:46
     apitest::XSpreadsheets2 xDocument css::uno::Reference<css::sheet::XSpreadsheetDocument>
-include/unoidl/unoidl.hxx:443
-    unoidl::ConstantValue  union unoidl::ConstantValue::(anonymous at /media/noel/disk2/libo6/include/unoidl/unoidl.hxx:443:5)
 include/unoidl/unoidl.hxx:444
-    unoidl::ConstantValue::(anonymous) booleanValue _Bool
+    unoidl::ConstantValue  union unoidl::ConstantValue::(anonymous at /media/noel/disk2/libo6/include/unoidl/unoidl.hxx:444:5)
 include/unoidl/unoidl.hxx:445
-    unoidl::ConstantValue::(anonymous) byteValue sal_Int8
+    unoidl::ConstantValue::(anonymous) booleanValue _Bool
 include/unoidl/unoidl.hxx:446
-    unoidl::ConstantValue::(anonymous) shortValue sal_Int16
+    unoidl::ConstantValue::(anonymous) byteValue sal_Int8
 include/unoidl/unoidl.hxx:447
-    unoidl::ConstantValue::(anonymous) unsignedShortValue sal_uInt16
+    unoidl::ConstantValue::(anonymous) shortValue sal_Int16
 include/unoidl/unoidl.hxx:448
-    unoidl::ConstantValue::(anonymous) longValue sal_Int32
+    unoidl::ConstantValue::(anonymous) unsignedShortValue sal_uInt16
 include/unoidl/unoidl.hxx:449
-    unoidl::ConstantValue::(anonymous) unsignedLongValue sal_uInt32
+    unoidl::ConstantValue::(anonymous) longValue sal_Int32
 include/unoidl/unoidl.hxx:450
-    unoidl::ConstantValue::(anonymous) hyperValue sal_Int64
+    unoidl::ConstantValue::(anonymous) unsignedLongValue sal_uInt32
 include/unoidl/unoidl.hxx:451
-    unoidl::ConstantValue::(anonymous) unsignedHyperValue sal_uInt64
+    unoidl::ConstantValue::(anonymous) hyperValue sal_Int64
 include/unoidl/unoidl.hxx:452
-    unoidl::ConstantValue::(anonymous) floatValue float
+    unoidl::ConstantValue::(anonymous) unsignedHyperValue sal_uInt64
 include/unoidl/unoidl.hxx:453
+    unoidl::ConstantValue::(anonymous) floatValue float
+include/unoidl/unoidl.hxx:454
     unoidl::ConstantValue::(anonymous) doubleValue double
 include/unotest/bootstrapfixturebase.hxx:37
     test::BootstrapFixtureBase m_directories class test::Directories
@@ -659,8 +653,8 @@ ucb/source/ucp/gio/gio_mount.hxx:51
 ucb/source/ucp/gio/gio_mount.hxx:52
     OOoMountOperationClass _gtk_reserved4 void (*)(void)
 ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx:73
-    hierarchy_ucp::DataSupplier_Impl m_aIterator class HierarchyEntry::iterator
-ucbhelper/source/client/proxydecider.cxx:127
+    hierarchy_ucp::DataSupplier_Impl m_aIterator const class HierarchyEntry::iterator
+ucbhelper/source/client/proxydecider.cxx:124
     ucbhelper::proxydecider_impl::InternetProxyDecider_Impl m_aEmptyProxy const struct ucbhelper::InternetProxyServer
 unoidl/source/sourceprovider-scanner.hxx:147
     unoidl::detail::SourceProviderInterfaceTypeEntityPad directMandatoryBases std::vector<DirectBase>
@@ -679,15 +673,15 @@ unoidl/source/unoidl-read.cxx:148
 unoidl/source/unoidl-read.cxx:149
     (anonymous namespace)::Entity interfaceDependencies std::set<OUString>
 unoidl/source/unoidlprovider.cxx:86
-    unoidl::detail::(anonymous namespace)::Memory16 byte unsigned char [2]
+    unoidl::detail::(anonymous namespace)::Memory16 byte const unsigned char [2]
 unoidl/source/unoidlprovider.cxx:96
-    unoidl::detail::(anonymous namespace)::Memory32 byte unsigned char [4]
+    unoidl::detail::(anonymous namespace)::Memory32 byte const unsigned char [4]
 unoidl/source/unoidlprovider.cxx:127
-    unoidl::detail::(anonymous namespace)::Memory64 byte unsigned char [8]
+    unoidl::detail::(anonymous namespace)::Memory64 byte const unsigned char [8]
 unoidl/source/unoidlprovider.cxx:455
-    unoidl::detail::MapEntry name struct unoidl::detail::(anonymous namespace)::Memory32
+    unoidl::detail::MapEntry name const struct unoidl::detail::(anonymous namespace)::Memory32
 unoidl/source/unoidlprovider.cxx:456
-    unoidl::detail::MapEntry data struct unoidl::detail::(anonymous namespace)::Memory32
+    unoidl::detail::MapEntry data const struct unoidl::detail::(anonymous namespace)::Memory32
 unotools/source/config/pathoptions.cxx:90
     SvtPathOptions_Impl m_aEmptyString const class rtl::OUString
 unotools/source/config/saveopt.cxx:77
@@ -784,8 +778,8 @@ vcl/unx/generic/print/bitmap_gfx.cxx:67
     psp::HexEncoder mpFileBuffer sal_Char [16400]
 vcl/unx/gtk/a11y/atkwrapper.hxx:49
     AtkObjectWrapper aParent const AtkObject
-vcl/unx/gtk/a11y/atkwrapper.hxx:78
-    AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
+vcl/unx/gtk/a11y/atkwrapper.hxx:80
+    AtkObjectWrapperClass aParentClass const AtkObjectClass
 vcl/unx/gtk/gloactiongroup.cxx:30
     GLOAction parent_instance GObject
 vcl/unx/gtk/glomenu.cxx:20
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index 9553918ad64d..6803ae25f894 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -206,16 +206,8 @@ sc/source/filter/html/htmlpars.cxx:3030
     (anonymous namespace)::CSSHandler::MemStr mn size_t
 sc/source/filter/inc/sheetdatacontext.hxx:62
     oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
-sc/source/ui/Accessibility/AccessibleText.cxx:52
-    ScViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:273
-    ScPreviewCellViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:289
-    ScPreviewHeaderCellViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:305
-    ScPreviewNoteViewForwarder maCellPos class ScAddress
-sc/source/ui/Accessibility/AccessibleText.cxx:1309
-    ScCsvViewForwarder maBoundBox tools::Rectangle
+sc/source/ui/dataprovider/sqldataprovider.cxx:41
+    sc::SQLFetchThread maURL class rtl::OUString
 sc/source/ui/inc/crdlg.hxx:33
     ScColOrRowDlg m_xBtnRows std::unique_ptr<weld::RadioButton>
 sc/source/ui/inc/delcodlg.hxx:39
@@ -302,6 +294,10 @@ sw/source/core/frmedt/fetab.cxx:79
     TableWait m_pWait const std::unique_ptr<SwWait>
 sw/source/core/layout/dbg_lay.cxx:170
     SwImplEnterLeave nAction enum DbgAction
+sw/source/ui/config/mailconfigpage.cxx:56
+    SwTestAccountSettingsDialog m_xEstablish std::unique_ptr<weld::Label>
+sw/source/ui/config/mailconfigpage.cxx:57
+    SwTestAccountSettingsDialog m_xFind std::unique_ptr<weld::Label>
 sw/source/ui/envelp/labfmt.hxx:75
     SwLabFormatPage m_xPreview std::unique_ptr<weld::CustomWeld>
 sw/source/ui/inc/mmresultdialogs.hxx:72
@@ -333,7 +329,7 @@ sw/source/uibase/inc/uivwimp.hxx:95
 sw/source/uibase/inc/unodispatch.hxx:46
     SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard class SolarMutexGuard
 toolkit/source/awt/stylesettings.cxx:90
-    toolkit::StyleMethodGuard m_aGuard class SolarMutexGuard
+    toolkit::StyleMethodGuard m_aGuard const class SolarMutexGuard
 unoidl/source/unoidlprovider.cxx:672
     unoidl::detail::(anonymous namespace)::UnoidlCursor reference1_ rtl::Reference<UnoidlProvider>
 unoidl/source/unoidlprovider.cxx:673
@@ -344,7 +340,7 @@ vcl/inc/opengl/zone.hxx:46
     OpenGLVCLContextZone aZone const class OpenGLZone
 vcl/inc/salprn.hxx:44
     SalPrinterQueueInfo mpPortName std::unique_ptr<OUString>
-vcl/source/app/salvtables.cxx:564
+vcl/source/app/salvtables.cxx:606
     SalInstanceContainer m_xContainer VclPtr<vcl::Window>
 vcl/source/gdi/jobset.cxx:35
     ImplOldJobSetupData cDeviceName char [32]
@@ -356,7 +352,7 @@ vcl/unx/generic/print/prtsetup.hxx:73
     RTSPaperPage m_xContainer std::unique_ptr<weld::Widget>
 vcl/unx/generic/print/prtsetup.hxx:108
     RTSDevicePage m_xContainer std::unique_ptr<weld::Widget>
-vcl/unx/gtk3/gtk3gtkinst.cxx:2255
+vcl/unx/gtk3/gtk3gtkinst.cxx:2267
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link const AtkHyperlink
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index 669d348e7f89..960d1d23f34c 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -146,8 +146,8 @@ cui/source/inc/cuihyperdlg.hxx:57
     SvxHlinkCtrl aRdOnlyForwarder class SfxStatusForwarder
 cui/source/inc/cuihyperdlg.hxx:77
     SvxHpLinkDlg maCtrl class SvxHlinkCtrl
-cui/source/inc/grfpage.hxx:62
-    SvxGrfCropPage bReset _Bool
+cui/source/inc/cuitabline.hxx:95
+    SvxLineTabPage m_nNumMenuGalleryItems long
 dbaccess/source/core/dataaccess/documentdefinition.cxx:287
     dbaccess::LifetimeCoupler m_xClient Reference<class com::sun::star::uno::XInterface>
 desktop/qa/desktop_lib/test_desktop_lib.cxx:178
@@ -364,8 +364,8 @@ sc/source/filter/xml/xmlexternaltabi.hxx:112
     ScXMLExternalRefCellContext mnCellType sal_Int16
 sc/source/ui/inc/AccessibleText.hxx:194
     ScAccessiblePreviewHeaderCellTextData mbRowHeader _Bool
-sc/source/ui/inc/AccessibleText.hxx:223
-    ScAccessibleHeaderTextData mbHeader _Bool
+sc/source/ui/inc/AccessibleText.hxx:266
+    ScAccessibleCsvTextData maBoundBox tools::Rectangle
 sc/source/ui/inc/datastream.hxx:108
     sc::DataStream mnSettings sal_uInt32
 sc/source/ui/inc/preview.hxx:47
@@ -394,8 +394,6 @@ slideshow/source/engine/opengl/TransitionImpl.hxx:297
     Vertex texcoord glm::vec2
 slideshow/source/engine/slideshowimpl.cxx:1043
     (anonymous namespace)::SlideShowImpl::PrefetchPropertiesFunc mpSlideShowImpl class (anonymous namespace)::SlideShowImpl *const
-slideshow/source/inc/shapeattributelayer.hxx:501
-    slideshow::internal::ShapeAttributeLayer mnCharRotationAngle double
 soltools/cpp/cpp.h:143
     macroValidator pMacro Nlist *
 starmath/inc/view.hxx:158
@@ -490,8 +488,6 @@ vcl/inc/opengl/RenderList.hxx:29
     Vertex color glm::vec4
 vcl/inc/opengl/RenderList.hxx:30
     Vertex lineData glm::vec4
-vcl/inc/printerinfomanager.hxx:100
-    psp::PrinterInfoManager::Printer m_bModified _Bool
 vcl/inc/salmenu.hxx:34
     SalItemParams nBits enum MenuItemBits
 vcl/inc/salmenu.hxx:42
@@ -536,8 +532,8 @@ vcl/unx/generic/app/wmadaptor.cxx:1270
     _mwmhints status unsigned long
 vcl/unx/gtk/a11y/atkwrapper.hxx:49
     AtkObjectWrapper aParent const AtkObject
-vcl/unx/gtk/a11y/atkwrapper.hxx:78
-    AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
+vcl/unx/gtk/a11y/atkwrapper.hxx:80
+    AtkObjectWrapperClass aParentClass const AtkObjectClass
 vcl/unx/gtk/gloactiongroup.cxx:30
     GLOAction parent_instance GObject
 vcl/unx/gtk/glomenu.cxx:20