diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2021-06-16 14:04:12 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2021-06-16 18:37:57 +0200 |
| commit | d32d2fd301357df94d1930420b89415e1fe69688 (patch) | |
| tree | d036f36f5013c79c38777c187b5779b6ab639fcb /compilerplugins | |
| parent | c9ba420bfe5c31e67a7555c8f4a16d0bd7954a51 (diff) | |
Move enable_if from dummy template parameter to return type
...and drop the no-longer necessary loplugin:implicitboolconversion exclusion
(which had been necessary to avoid
> [CXX] vcl/source/window/dockingarea.cxx
> In file included from vcl/source/window/dockingarea.cxx:26:
> In file included from vcl/inc/svdata.hxx:26:
> include/o3tl/hash_combine.hxx:14:78: error: implicit conversion (Dependent) from 'bool' to 'std::enable_if_t<(sizeof(N) == 4), bool>' (aka 'typename enable_if<(sizeof(N) == 4), bool>::type') [loplugin:implicitboolconversion]
> template <typename T, typename N, std::enable_if_t<(sizeof(N) == 4), bool> = false>
> ^~~~~
etc.)
Change-Id: If764365213cf29f7dec6fdd6a773dc9894dd15bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117330
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/implicitboolconversion.cxx | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/compilerplugins/clang/implicitboolconversion.cxx b/compilerplugins/clang/implicitboolconversion.cxx index 7e708eb49843..14574e3cd420 100644 --- a/compilerplugins/clang/implicitboolconversion.cxx +++ b/compilerplugins/clang/implicitboolconversion.cxx @@ -907,12 +907,6 @@ void ImplicitBoolConversion::reportWarning(ImplicitCastExpr const * expr) { } } } - - // ignore template magic - StringRef aFileName = getFilenameOfLocation(compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(expr))); - if (loplugin::hasPathnamePrefix(aFileName, SRCDIR "/include/o3tl/hash_combine.hxx")) - return; - report( DiagnosticsEngine::Warning, "implicit conversion (%0) from %1 to %2", compat::getBeginLoc(expr)) |