loplugin:constfields in sw

Change-Id: I1eb6583bb9ec815bc0564b0d7c676f5b1fb9045f
Reviewed-on: https://gerrit.libreoffice.org/61177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 14 insertions, 7 deletions

diff --git a/compilerplugins/clang/staticconstfield.cxx b/compilerplugins/clang/staticconstfield.cxx
index bfc32a8c059f..79fda38531e9 100644
--- a/compilerplugins/clang/staticconstfield.cxx
+++ b/compilerplugins/clang/staticconstfield.cxx
@@ -84,13 +84,20 @@ bool StaticConstField::TraverseConstructorInitializer(CXXCtorInitializer* init)
             return true;
     }
 
-    if (found)
-    {
-        report(DiagnosticsEngine::Warning, "field can be static const", init->getSourceLocation())
-            << init->getSourceRange();
-        report(DiagnosticsEngine::Note, "field here", init->getMember()->getLocation())
-            << init->getMember()->getSourceRange();
-    }
+    if (!found)
+        return true;
+
+    std::string fn = handler.getMainFileName();
+    loplugin::normalizeDotDotInFilePath(fn);
+
+    // unusual case where a user constructor sets a field to one value, and a copy constructor sets it to a different value
+    if (fn == SRCDIR "/sw/source/core/attr/hints.cxx")
+        return true;
+
+    report(DiagnosticsEngine::Warning, "field can be static const", init->getSourceLocation())
+        << init->getSourceRange();
+    report(DiagnosticsEngine::Note, "field here", init->getMember()->getLocation())
+        << init->getMember()->getSourceRange();
 
     return true;
 }