diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-24 16:39:11 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-25 10:23:09 +0100 |
commit | fbe2d12f19dac29107e89ce4b3153fa6922633e5 (patch) | |
tree | 6e0784b76d1b696f07ceb35e60296e96a7a386b3 /compilerplugins | |
parent | dd42329b4a204d9d9dcac102095f144ea3eca791 (diff) |
loplugin:datamembershadow in SvxUnoTextRangeBase
make the superclass member private
Change-Id: I665d87bfdfc3d7804cd4cac6108f9bc65b9ca2b5
Reviewed-on: https://gerrit.libreoffice.org/48552
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
-rw-r--r-- | compilerplugins/clang/datamembershadow.cxx | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx index 520e1195f0ca..54e671daffa1 100644 --- a/compilerplugins/clang/datamembershadow.cxx +++ b/compilerplugins/clang/datamembershadow.cxx @@ -19,6 +19,7 @@ * Check for data member being shadowed. * * @TODO check for any members in superclass hierarchy with duplicate names, + * regardless of their visibility, * more specific names will make the code easier to read */ namespace @@ -84,12 +85,8 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl) if (loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stortree.hxx") || loplugin::isSamePathname(aFileName, SRCDIR "/store/source/stordata.hxx")) return true; - if (loplugin::isSamePathname(aFileName, SRCDIR "/svx/source/inc/cell.hxx")) - return true; if (loplugin::isSamePathname(aFileName, SRCDIR "/sw/source/uibase/inc/dbtree.hxx")) return true; - if (loplugin::isSamePathname(aFileName, SRCDIR "/vcl/unx/generic/print/genpspgraphics.cxx")) - return true; const CXXRecordDecl* parentCXXRecordDecl = dyn_cast<CXXRecordDecl>(fieldDecl->getDeclContext()); if (!parentCXXRecordDecl) { |