summaryrefslogtreecommitdiff
path: root/compilerplugins
diff options
context:
space:
mode:
authorNoel Grandin <noelgrandin@gmail.com>2021-07-03 20:26:18 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2021-07-05 19:00:45 +0200
commit6cb400f41df0dd108cdb4b4d3ec6656844814147 (patch)
tree15a38de0d82d59be10a74d6cdc5375e9c08b0dd6 /compilerplugins
parentb99e8c79bf630432fbb6a819d69da0bd2db7c80c (diff)
store the SfxItemSet inside SfxSetItem by value
rather than on the heap, avoiding an allocation Change-Id: I3f1504f9a2d4178a9ba59e98de182a0ab98cdce0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118356 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'compilerplugins')
-rw-r--r--compilerplugins/clang/redundantfcast.cxx3
1 files changed, 3 insertions, 0 deletions
diff --git a/compilerplugins/clang/redundantfcast.cxx b/compilerplugins/clang/redundantfcast.cxx
index d600aa5b79df..dc41ea63ded1 100644
--- a/compilerplugins/clang/redundantfcast.cxx
+++ b/compilerplugins/clang/redundantfcast.cxx
@@ -313,6 +313,9 @@ public:
// compile-time check of constant
if (fn == SRCDIR "/bridges/source/jni_uno/jni_bridge.cxx")
return false;
+ // TODO constructing a temporary to pass to a && param
+ if (fn == SRCDIR "/sc/source/ui/view/viewfunc.cxx")
+ return false;
return true;
}