diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-10-26 10:56:15 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-10-26 14:50:25 +0100 |
| commit | 8a9a0447807ad7544a3df5a067dd26a4ee6613f1 (patch) | |
| tree | d7463d4940ce8ca4d0af770ba1145844544ea843 /compilerplugins | |
| parent | c277bedb0ac82194b05b4eac2e6e7367672c185f (diff) | |
Remove unmaintained Executable_libtest
<https://lists.freedesktop.org/archives/libreoffice/2020-October/086169.html>
"Re: Is Executable_libtest still useful?":
>> so I wonder whether that program is actually still maintained and used by
>> anybody. (At least the last dozen or so changes to smoketest/libtest.cxx
>> were of the generic loplugin/typos/tools::Long etc. kind, and we could spare
>> ourselves future such work if we removed the file should it indeed be dead
>> code.)
>
> I think this can be removed. https://gitlab.com/ojwb/lloconv does the
> same and it seems to be maintained.
Change-Id: I039e161ecf4904210e246e389cf4ba85124a66fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104803
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/shouldreturnbool.cxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/compilerplugins/clang/shouldreturnbool.cxx b/compilerplugins/clang/shouldreturnbool.cxx index 23749d6b6428..1372d8103374 100644 --- a/compilerplugins/clang/shouldreturnbool.cxx +++ b/compilerplugins/clang/shouldreturnbool.cxx @@ -42,8 +42,7 @@ public: if (loplugin::isSamePathname(fn, SRCDIR "/sal/rtl/alloc_cache.cxx")) return; // false +, slightly odd usage, but not wrong - if (loplugin::isSamePathname(fn, SRCDIR "/libreofficekit/qa/tilebench/tilebench.cxx") - || loplugin::isSamePathname(fn, SRCDIR "/smoketest/libtest.cxx")) + if (loplugin::isSamePathname(fn, SRCDIR "/libreofficekit/qa/tilebench/tilebench.cxx")) return; // uses the Unix convention of "non-zero return indicates error" if (loplugin::isSamePathname(fn, SRCDIR "/idlc/source/idlcproduce.cxx")) |