loplugin:unuseddefaultparams in vcl and xmloff

and teach the plugin about code that takes the address of a function

Change-Id: Ia9d5afef44520aca236659e8176f1e27135ef4fc
Reviewed-on: https://gerrit.libreoffice.org/22861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

1 files changed, 15 insertions, 0 deletions

diff --git a/compilerplugins/clang/unuseddefaultparams.cxx b/compilerplugins/clang/unuseddefaultparams.cxx
index 6906a93c2271..a194be26e726 100644
--- a/compilerplugins/clang/unuseddefaultparams.cxx
+++ b/compilerplugins/clang/unuseddefaultparams.cxx
@@ -68,8 +68,11 @@ public:
         myfile.close();
     }
 
+    bool shouldVisitTemplateInstantiations () const { return true; }
+
     bool VisitCallExpr(CallExpr * callExpr);
     bool VisitFunctionDecl( const FunctionDecl* functionDecl );
+    bool VisitDeclRefExpr( const DeclRefExpr* declRefExpr );
 private:
     MyFuncInfo niceName(const FunctionDecl* functionDecl);
 };
@@ -208,6 +211,18 @@ bool UnusedDefaultParams::VisitFunctionDecl( const FunctionDecl* functionDecl )
     return true;
 }
 
+// this catches places that take the address of a method
+bool UnusedDefaultParams::VisitDeclRefExpr( const DeclRefExpr* declRefExpr )
+{
+    const Decl* functionDecl = declRefExpr->getDecl();
+    if (!isa<FunctionDecl>(functionDecl)) {
+        return true;
+    }
+    MyFuncInfo funcInfo = niceName(dyn_cast<FunctionDecl>(functionDecl));
+    callSet.insert(funcInfo);
+    return true;
+}
+
 loplugin::Plugin::Registration< UnusedDefaultParams > X("unuseddefaultparams", false);
 
 }