diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2021-07-21 13:36:13 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-07-21 14:03:49 +0200 |
| commit | 1cfa72a83101d7ea1f89b2c20a6c29d12e8da933 (patch) | |
| tree | 318032bd20ff9943c9039b539c8a68c6a71b4e10 /compilerplugins | |
| parent | 99cd1d8834bb708afc81c825ff2b7992b7acb37d (diff) | |
IsVertical->IsEffectivelyVertical, GetDirectVertical->GetVertical
Before commit 653b53287ca09a9ffe3f5ce0242919e719c1086c, editengine
objects had a pair IsVertical/SetVertical, which queried and set
a boolean flag (and SetVertical also had a second argument to set
another flag).
The mentioned commit had introduced an inconsistency, changing
SetVertical to only set a single flag, but at the same time making
IsVertical to return a synthesized result from two values: vertical
and rotation. Additionally, GetDirectVertical was introduced to
complement SetVertical.
In many places, the use of synthetic IsVertical looks suspicious,
especially where it is used in combinations with SetVertical. But
here I don't change existing logic, and only rename the methods,
so that in case someone sees an actual problem, it would be easier
to spot the method mismatch.
The end result is that now we have a proper getter/setter pair
GetVertical/SetVertical, and also IsEffectivelyVertical, named to
reflect that it calculates its return value.
Change-Id: I38e2b7c5bd7af0787dd7a1c48e1385138dac80b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119315
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/unusedmethods.results | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index b89889feb939..73fd7a66791c 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -515,7 +515,7 @@ include/drawinglayer/primitive3d/baseprimitive3d.hxx:112 include/drawinglayer/tools/primitive2dxmldump.hxx:45 void drawinglayer::Primitive2dXmlDump::dump(const class drawinglayer::primitive2d::Primitive2DContainer &,const class rtl::OUString &) include/editeng/editeng.hxx:241 - _Bool EditEngine::GetDirectVertical() const + _Bool EditEngine::GetVertical() const include/editeng/editeng.hxx:243 enum TextRotation EditEngine::GetRotation() const include/editeng/editeng.hxx:472 |