summaryrefslogtreecommitdiff
path: root/compilerplugins
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2022-02-17 09:36:32 +0100
committerStephan Bergmann <sbergman@redhat.com>2022-02-17 22:35:57 +0100
commit3c535b25110cb2b9cde41dd469d9ece2b52b1444 (patch)
tree6c2a049d24b7a88e069eb60c6b26122c6eadb07a /compilerplugins
parent9eb9083ff2fdaeb96399a0830a4394de4e29ef64 (diff)
Don't exclude vcl/source/app/salplug.cxx from loplugin:externandnotdefined
Whatever exactly the original reason to do so, it appears to no longer be relevant. (Maybe that salplug.cxx got reworked in the meantime?) Change-Id: I5187635dcb095ca505b38992b19770fe232f5124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130115 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'compilerplugins')
-rw-r--r--compilerplugins/clang/externandnotdefined.cxx7
1 files changed, 0 insertions, 7 deletions
diff --git a/compilerplugins/clang/externandnotdefined.cxx b/compilerplugins/clang/externandnotdefined.cxx
index 676f666ba621..5fd59ca4b58c 100644
--- a/compilerplugins/clang/externandnotdefined.cxx
+++ b/compilerplugins/clang/externandnotdefined.cxx
@@ -11,8 +11,6 @@
#include <string>
-#include "config_clang.h"
-
#include "plugin.hxx"
// Having an extern prototype for a method in a module and not actually declaring that method is dodgy.
@@ -61,11 +59,6 @@ bool ExternAndNotDefined::VisitFunctionDecl(const FunctionDecl * functionDecl) {
{
return true;
}
- StringRef fileName { getFilenameOfLocation(functionDecl->getLocation()) };
- // keeps the code structure of salplug.cxx easier to follow
- if (fileName == SRCDIR "/vcl/source/app/salplug.cxx") {
- return true;
- }
report(
DiagnosticsEngine::Warning,
"extern prototype in main file without definition",